From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v5 0/2] Show container ip in summary and network tab
Date: Tue, 27 May 2025 16:04:44 +0200 [thread overview]
Message-ID: <20250527140446.365983-1-g.goller@proxmox.com> (raw)
Show the ip/hwaddress of the network interfaces of containers in the summary
tab of the container and in the network tab on a per-interface basis.
This series was originally by Leo Nunner:
https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/
Note that the pve-network part has been merged already
(https://lore.proxmox.com/pve-devel/bbc59ae4-e552-4e2f-9bb3-8b4e47bd6cb1@proxmox.com/).
v5, thanks @Thomas:
- fix network interfaces list not displayed correctly when nothing configured
- use Proxmox.Async
- make summary container status scrollable to show all the IPs
- change 'dhcp' to 'dynamic' as we don't know if it's dhcp for sure
- (note that this version only contains the pve-manager patches, the
pve-network part has been merged already)
v4, thanks @Daniel:
- remove duplicate code (copy paste error)
- rebase on latest master
v3, thanks @Thomas, @Maximiliano:
- fixed wording in schema description
- stay backwards-compatible by keeping old attributes
- use array reference instead of array
v2, thanks @Dominik:
- show if ip is static or dynamic (dhcp)
- show multiple ips per interface
- refactor/reuse AgentIPView instead of adding ContainerIPView component
- various other small improvements
pve-manager:
Gabriel Goller (2):
lxc: show dynamically assigned IPs in network tab
guest: refactor and reuse AgentIPView for containers
www/manager6/Makefile | 2 +-
www/manager6/lxc/Network.js | 115 ++++++++++----
www/manager6/panel/GuestStatusView.js | 140 +++++++++++++++++-
www/manager6/panel/GuestSummary.js | 1 +
.../{qemu/AgentIPView.js => panel/IPView.js} | 79 ++--------
5 files changed, 235 insertions(+), 102 deletions(-)
rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (58%)
Summary over all repositories:
5 files changed, 235 insertions(+), 102 deletions(-)
--
Generated by git-murpp 0.8.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-05-27 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 14:04 Gabriel Goller [this message]
2025-05-27 14:04 ` [pve-devel] [PATCH pve-manager v5 1/2] lxc: show dynamically assigned IPs in " Gabriel Goller
2025-05-27 14:04 ` [pve-devel] [PATCH pve-manager v5 2/2] guest: refactor and reuse AgentIPView for containers Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527140446.365983-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal