From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox_login_manager v2] refactor: replace deprecated functions and properties
Date: Thu, 22 May 2025 10:34:06 +0200 [thread overview]
Message-ID: <20250522083406.30203-1-s.shaji@proxmox.com> (raw)
As of flutter v3.22 the `background` property is deprecated. Also the
`withOpacity` function is also deprecated as of flutter v3.27.
This commit replaces the use of `background` property with
`surfaceContainer` to align with the changes made in the following
change [0] in `pve_flutter_frontend`. Additionaly the `withOpacity`
function is also replaced with `withValues` function.
- [0] https://lore.proxmox.com/all/20250505120355.31056-1-s.shaji@proxmox.com/
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
changes since v1:
* Removed all `dart fix` related changes
lib/proxmox_login_form.dart | 2 +-
lib/proxmox_login_selector.dart | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index 5916563..94187f5 100644
--- a/lib/proxmox_login_form.dart
+++ b/lib/proxmox_login_form.dart
@@ -729,7 +729,7 @@ class ProxmoxProgressOverlay extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Container(
- decoration: BoxDecoration(color: Colors.black.withOpacity(0.5)),
+ decoration: BoxDecoration(color: Colors.black.withValues(alpha: 0.5)),
child: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart
index fb1218b..ba84d7d 100644
--- a/lib/proxmox_login_selector.dart
+++ b/lib/proxmox_login_selector.dart
@@ -30,7 +30,7 @@ class _ProxmoxLoginSelectorState extends State<ProxmoxLoginSelector> {
@override
Widget build(BuildContext context) {
return Scaffold(
- backgroundColor: Theme.of(context).colorScheme.background,
+ backgroundColor: Theme.of(context).colorScheme.surfaceContainer,
appBar: AppBar(
centerTitle: false,
title: const Column(
--
2.39.5 (Apple Git-154)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-05-22 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 8:34 Shan Shaji [this message]
2025-06-04 10:00 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522083406.30203-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal