[pve-devel] [PATCH network] api: controller: iterate over keys instead of whole map

[pve-devel] [PATCH network] api: controller: iterate over keys instead of whole map

[Gabriel Goller]

Previously, we iterated over the entire hash (keys and values), which
added unnecessary data to the configuration. This commit changes the
loop to iterate only over the hash keys.

Nothing should change as the garbled properties were removed down the
line anyway.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/API2/Network/SDN/Controllers.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/API2/Network/SDN/Controllers.pm b/src/PVE/API2/Network/SDN/Controllers.pm
index 38a685d48d06..b776273a6278 100644
--- a/src/PVE/API2/Network/SDN/Controllers.pm
+++ b/src/PVE/API2/Network/SDN/Controllers.pm
@@ -235,7 +235,7 @@ __PACKAGE__->register_method ({
 		PVE::SectionConfig::delete_from_config($scfg, $options, $opts, $delete);
 	    }
 
-	    foreach my $k (%$opts) {
+	    for my $k (keys %{$opts}) {
 		$scfg->{$k} = $opts->{$k};
 	    }
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH network] api: controller: iterate over keys instead of whole map

[Thomas Lamprecht]

On Tue, 20 May 2025 17:01:01 +0200, Gabriel Goller wrote:
> Previously, we iterated over the entire hash (keys and values), which
> added unnecessary data to the configuration. This commit changes the
> loop to iterate only over the hash keys.
> 
> Nothing should change as the garbled properties were removed down the
> line anyway.
> 
> [...]

Applied, thanks!

[1/1] api: controller: iterate over keys instead of whole map
      commit: 7af377c9024aa47f337e374317df5d77cb85bdfd


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel