public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 2/2] rbd plugin: status: explain why percentage value can be different from Ceph
Date: Tue, 13 May 2025 15:31:22 +0200	[thread overview]
Message-ID: <20250513133122.94322-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250513133122.94322-1-f.ebner@proxmox.com>

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/RBDPlugin.pm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index 154fa00..b56f8e4 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -703,6 +703,12 @@ sub status {
 
     # max_avail -> max available space for data w/o replication in the pool
     # stored -> amount of user data w/o replication in the pool
+    # NOTE These values are used because they are most natural from a user perspective.
+    # However, the %USED/percent_used value in Ceph is calculated from values before factoring out
+    # replication, namely 'bytes_used / (bytes_used + avail_raw)'. In certain setups, e.g. with LZ4
+    # compression, this percentage can be noticeably different form the percentage
+    # 'stored / (stored + max_avail)' shown in the Proxmox VE CLI/UI. See also src/mon/PGMap.cc from
+    # the Ceph source code, which also mentions that 'stored' is an approximation.
     my $free = $d->{stats}->{max_avail};
     my $used = $d->{stats}->{stored};
     my $total = $used + $free;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-05-13 13:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 13:31 [pve-devel] [PATCH storage 1/2] rbd plugin: status: drop outdated fallback Fiona Ebner
2025-05-13 13:31 ` Fiona Ebner [this message]
2025-05-14  8:22   ` [pve-devel] [PATCH storage 2/2] rbd plugin: status: explain why percentage value can be different from Ceph Fiona Ebner
2025-05-14  9:06     ` Fabian Grünbichler
2025-05-14  9:31       ` Fiona Ebner
2025-05-14 11:07         ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513133122.94322-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal