public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-lxc-syscalld 3/4] d/postinst: create link to new socket location on upgrade
Date: Tue, 13 May 2025 12:56:51 +0200	[thread overview]
Message-ID: <20250513105652.67403-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250513105652.67403-1-f.ebner@proxmox.com>

This allows containers started with a configuration using the old
socket path to continue calling in to the pve-lxc-syscalld, except for
a brief time window after the new runtime dir is used before the
postinst script runs. However, such a time window was/is already
present during service restart (and thus during package upgrade),
since pve-lxc-syscalld doesn't currently implement graceful reloading.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/postinst | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 debian/postinst

diff --git a/debian/postinst b/debian/postinst
new file mode 100644
index 0000000..97abc0c
--- /dev/null
+++ b/debian/postinst
@@ -0,0 +1,19 @@
+#!/bin/sh
+
+set -e
+
+#DEBHELPER#
+
+case "$1" in
+  configure)
+    if test -n "$2"; then
+      # TODO: remove once PVE 10.0 is released
+      if dpkg --compare-versions "$2" 'lt' '1.3.1'; then
+        ln -s -f /run/pve-lxc-syscalld/lxc-syscalld.sock /run/pve/lxc-syscalld.sock
+      fi
+    fi
+    ;;
+
+esac
+
+exit 0
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-05-13 10:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 10:56 [pve-devel] [RFC manager/lxc-syscalld/container 0/4] avoid using generic runtime directory name for pve-lxc-syscalld Fiona Ebner
2025-05-13 10:56 ` [pve-devel] [PATCH manager 1/4] add tpmfiles.d config to create /run/pve directory Fiona Ebner
2025-05-14 18:08   ` Thomas Lamprecht
2025-05-15  8:26     ` Fiona Ebner
2025-05-13 10:56 ` [pve-devel] [PATCH pve-lxc-syscalld 2/4] service: avoid using generic runtime directory name Fiona Ebner
2025-05-14 14:33   ` Thomas Lamprecht
2025-05-15  8:41     ` Fiona Ebner
2025-05-15  9:24       ` Thomas Lamprecht
2025-05-13 10:56 ` Fiona Ebner [this message]
2025-05-13 10:56 ` [pve-devel] [PATCH container 4/4] seccomp config: adapt to new lxc-syscalld runtime directory Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513105652.67403-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal