From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v5 2/3] print warning for PVE::Storage::path errors instead of failing
Date: Tue, 13 May 2025 10:03:57 +0200 [thread overview]
Message-ID: <20250513080358.49500-7-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250513080358.49500-1-m.koeppl@proxmox.com>
Co-authored-by: Stefan Hrdlicka
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index e02bf7d4..68bbf4ce 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2132,7 +2132,8 @@ sub destroy_vm {
return if !$volid || $volid =~ m|^/|;
return if $volids->{$volid};
- my ($path, $owner) = PVE::Storage::path($storecfg, $volid);
+ my ($path, $owner) = eval { PVE::Storage::path($storecfg, $volid) };
+ log_warn("failed to get path and owner of volume '$volid': $@\n") if $@;
return if !$path || !$owner || ($owner != $vmid);
$volids->{$volid} = 1;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-13 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 8:03 [pve-devel] [PATCH container/qemu-server v5 0/7] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 1/4] fix #3711: lxc: print warning if storage for mounted volume does not exist anymore Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume() Michael Köppl
2025-05-13 13:37 ` Daniel Kral
2025-05-13 13:48 ` Daniel Kral
2025-05-14 14:18 ` Thomas Lamprecht
2025-05-19 7:50 ` Michael Köppl
2025-05-19 8:09 ` Thomas Lamprecht
2025-05-20 9:12 ` Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 3/4] fix #3711: lxc: allow removing unused mp if storage no longer exists Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 4/4] add linked clone check when destroying container Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH qemu-server v5 1/3] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-05-13 8:03 ` Michael Köppl [this message]
2025-05-13 8:03 ` [pve-devel] [PATCH qemu-server v5 3/3] mark volumes pending detach as unused if storage was removed Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513080358.49500-7-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox