public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/5] test: adapt tests to use verbose disk size suffixes
Date: Mon, 12 May 2025 14:41:27 +0200	[thread overview]
Message-ID: <20250512124129.91914-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250512124129.91914-1-f.ebner@proxmox.com>

The 'disk-size' format in the JSON schema in pve-common was changed to
print more verbose, non-ambiguous disk size suffixes. Adapt the tests
to match how configurations are actually written now.

Bump the corresponding build-dependency in d/control.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/control            | 2 +-
 test/replication_test1.pl | 2 +-
 test/replication_test2.pl | 2 +-
 test/replication_test3.pl | 2 +-
 test/replication_test4.pl | 2 +-
 test/replication_test5.pl | 4 ++--
 test/replication_test6.pl | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/debian/control b/debian/control
index 7003f28b..34455804 100644
--- a/debian/control
+++ b/debian/control
@@ -11,7 +11,7 @@ Build-Depends: debhelper-compat (= 13),
                libpve-access-control (>= 8.0.7),
                libpve-cluster-api-perl,
                libpve-cluster-perl (>= 6.1-6),
-               libpve-common-perl (>= 8.2.3),
+               libpve-common-perl (>= 8.3.2),
                libpve-guest-common-perl (>= 5.1.1),
                libpve-http-server-perl (>= 2.0-12),
                libpve-notify-perl,
diff --git a/test/replication_test1.pl b/test/replication_test1.pl
index 7a31cfc3..c0d1ac93 100755
--- a/test/replication_test1.pl
+++ b/test/replication_test1.pl
@@ -28,7 +28,7 @@ $ReplicationTestEnv::mocked_vm_configs = {
     900 => {
 	node => 'node1',
 	snapshots => {},
-	ide0 => 'local-lvm:vm-900-disk-1,size=4G',
+	ide0 => 'local-lvm:vm-900-disk-1,size=4GiB',
 	memory => 512,
 	ide2 => 'none,media=cdrom',
     },
diff --git a/test/replication_test2.pl b/test/replication_test2.pl
index ff5fbaff..ccf3dd47 100755
--- a/test/replication_test2.pl
+++ b/test/replication_test2.pl
@@ -51,7 +51,7 @@ $ReplicationTestEnv::mocked_vm_configs = {
     900 => {
 	node => 'node1',
 	snapshots => {},
-	ide0 => 'local-lvm:vm-900-disk-1,size=4G',
+	ide0 => 'local-lvm:vm-900-disk-1,size=4GiB',
 	memory => 512,
 	ide2 => 'none,media=cdrom',
     },
diff --git a/test/replication_test3.pl b/test/replication_test3.pl
index 54004c70..192be476 100755
--- a/test/replication_test3.pl
+++ b/test/replication_test3.pl
@@ -35,7 +35,7 @@ $ReplicationTestEnv::mocked_vm_configs = {
     900 => {
 	node => 'node1',
 	snapshots => {},
-	ide0 => 'local-lvm:vm-900-disk-1,size=4G',
+	ide0 => 'local-lvm:vm-900-disk-1,size=4GiB',
 	memory => 512,
 	ide2 => 'none,media=cdrom',
     },
diff --git a/test/replication_test4.pl b/test/replication_test4.pl
index 38fef0e3..b3dfa5ff 100755
--- a/test/replication_test4.pl
+++ b/test/replication_test4.pl
@@ -42,7 +42,7 @@ $ReplicationTestEnv::mocked_vm_configs = {
     900 => {
 	node => 'node1',
 	snapshots => {},
-	ide0 => 'local-lvm:vm-900-disk-1,size=4G',
+	ide0 => 'local-lvm:vm-900-disk-1,size=4GiB',
 	memory => 512,
 	ide2 => 'none,media=cdrom',
     },
diff --git a/test/replication_test5.pl b/test/replication_test5.pl
index b884881e..64717a6a 100755
--- a/test/replication_test5.pl
+++ b/test/replication_test5.pl
@@ -100,7 +100,7 @@ $ReplicationTestEnv::mocked_vm_configs = {
     900 => {
 	node => 'node1',
 	snapshots => {},
-	ide0 => 'local-zfs:vm-900-disk-1,size=4G',
+	ide0 => 'local-zfs:vm-900-disk-1,size=4GiB',
 	memory => 512,
 	ide2 => 'none,media=cdrom',
     },
@@ -122,7 +122,7 @@ for (my $i = 0; $i < 15; $i++) {
 }
 
 # add a new, disk (but disk does not exist, so replication fails)
-$ReplicationTestEnv::mocked_vm_configs->{900}->{ide1} =  'local-zfs:vm-900-disk-2,size=4G';
+$ReplicationTestEnv::mocked_vm_configs->{900}->{ide1} =  'local-zfs:vm-900-disk-2,size=4GiB';
 for (my $i = 0; $i < 15; $i++) {
     ReplicationTestEnv::track_jobs($ctime);
     $ctime += 60;
diff --git a/test/replication_test6.pl b/test/replication_test6.pl
index 5b2303b5..0e547d34 100755
--- a/test/replication_test6.pl
+++ b/test/replication_test6.pl
@@ -42,7 +42,7 @@ $ReplicationTestEnv::mocked_vm_configs = {
     900 => {
 	node => 'node1',
 	snapshots => {},
-	ide0 => 'local-zfs:vm-900-disk-1,size=4G',
+	ide0 => 'local-zfs:vm-900-disk-1,size=4GiB',
 	memory => 512,
 	ide2 => 'none,media=cdrom',
     },
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-05-12 12:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 12:41 [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH common 1/5] " Fiona Ebner
2025-06-01  9:48   ` Thomas Lamprecht
2025-05-12 12:41 ` [pve-devel] [PATCH manager 2/5] vzdump: use verbose size suffix when logging archive file size Fiona Ebner
2025-05-12 12:41 ` Fiona Ebner [this message]
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 4/5] test: fix tests for changes when printing disk size suffix Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 5/5] test: adapt all tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 13:00 ` [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-06-01  9:51   ` Thomas Lamprecht
2025-06-02 11:21     ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250512124129.91914-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal