From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/5] vzdump: use verbose size suffix when logging archive file size
Date: Mon, 12 May 2025 14:41:26 +0200 [thread overview]
Message-ID: <20250512124129.91914-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250512124129.91914-1-f.ebner@proxmox.com>
The single-letter suffixes are ambiguous and especially in the context
of disks, the powers of ten are usually used. Use exact suffixes
instead when logging the archive file size.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/VZDump.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 58fa0f64..a7143926 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -235,19 +235,19 @@ sub format_size {
my $kb = $size / 1024;
if ($kb < 1024) {
- return int ($kb) . "KB";
+ return int ($kb) . "KiB";
}
my $mb = $size / (1024*1024);
if ($mb < 1024) {
- return int ($mb) . "MB";
+ return int ($mb) . "MiB";
}
my $gb = $mb / 1024;
if ($gb < 1024) {
- return sprintf ("%.2fGB", $gb);
+ return sprintf ("%.2fGiB", $gb);
}
my $tb = $gb / 1024;
- return sprintf ("%.2fTB", $tb);
+ return sprintf ("%.2fTiB", $tb);
}
sub format_time {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-12 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 12:41 [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH common 1/5] " Fiona Ebner
2025-06-01 9:48 ` Thomas Lamprecht
2025-05-12 12:41 ` Fiona Ebner [this message]
2025-05-12 12:41 ` [pve-devel] [PATCH manager 3/5] test: adapt tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 4/5] test: fix tests for changes when printing disk size suffix Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 5/5] test: adapt all tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 13:00 ` [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-06-01 9:51 ` Thomas Lamprecht
2025-06-02 11:21 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512124129.91914-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal