From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH dart_api_client 1/1] change exception toString to only print details if not null
Date: Mon, 5 May 2025 09:28:45 +0200 [thread overview]
Message-ID: <20250505072845.28299-1-m.koeppl@proxmox.com> (raw)
Without this check, the toString method returns '-> null' at the end of
the exception message if there are no details.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
lib/src/proxmox_api_exception.dart | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/src/proxmox_api_exception.dart b/lib/src/proxmox_api_exception.dart
index 8dddc7c..5c6f343 100644
--- a/lib/src/proxmox_api_exception.dart
+++ b/lib/src/proxmox_api_exception.dart
@@ -7,6 +7,6 @@ class ProxmoxApiException implements Exception {
@override
String toString() {
- return '$message -> $details';
+ return details != null ? '$message -> $details' : message;
}
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-05-05 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 7:28 Michael Köppl [this message]
2025-05-05 15:44 ` Shan Shaji
2025-05-21 11:04 ` Dominik Csapak
2025-05-23 7:51 ` Michael Köppl
2025-06-04 11:11 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505072845.28299-1-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal