From: Alexander Abraham <a.abraham@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend_null 0/2] fix #4976
Date: Tue, 29 Apr 2025 15:16:43 +0200 [thread overview]
Message-ID: <20250429131645.106612-1-a.abraham@proxmox.com> (raw)
This patches fixes bug 4976 in which the UI for nodes that are
offline was reporting a "null" error. In the API client, error-handling
for POST requests was changed to be more explicit and in the app's UI
the case of a node suddenly being offline was handled. Viewing the
information for a node that is offline was made impossible.
proxmox_dart_api_client:
Alexander Abraham (1):
fix #4976: dart_api_client: Improved error-handling for POST requests.
lib/src/client.dart | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
pve_flutter_frontend:
Alexander Abraham (1):
fix #4976: ui: Offline-status handled adequately in the UI.
lib/bloc/pve_node_overview_bloc.dart | 79 ++++++++++++++++++----------
lib/main.dart | 3 ++
lib/pages/main_layout_slim.dart | 58 ++++++++++++++++----
3 files changed, 101 insertions(+), 39 deletions(-)
Summary over all repositories:
4 files changed, 110 insertions(+), 44 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-04-29 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 13:16 Alexander Abraham [this message]
2025-04-29 13:16 ` [pve-devel] [PATCH dart_api_client 1/1] fix #4976: Request errors are Alexander Abraham
2025-05-02 10:19 ` Michael Köppl
2025-05-05 13:03 ` Michael Köppl
2025-04-29 13:16 ` [pve-devel] [PATCH flutter_frontend 1/1] fix #4976: ui: Nodes offline Alexander Abraham
2025-05-02 11:32 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429131645.106612-1-a.abraham@proxmox.com \
--to=a.abraham@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal