public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager stable-8 v3 2/3] pve8to9: move checklist to dedicated subcommand
Date: Tue, 29 Apr 2025 13:36:45 +0200	[thread overview]
Message-ID: <20250429113646.25738-6-f.weber@proxmox.com> (raw)
In-Reply-To: <20250429113646.25738-1-f.weber@proxmox.com>

This allows to introduce other subcommands, e.g. for manual actions
rqeuired before the upgrade.

TODO: Update the manpage.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---

Notes:
    new in v3

 PVE/CLI/pve8to9.pm | 4 +++-
 bin/Makefile       | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 42b7073b..fbb96491 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1538,6 +1538,8 @@ __PACKAGE__->register_method ({
 	return undef;
     }});
 
-our $cmddef = [ __PACKAGE__, 'checklist', [], {}];
+our $cmddef = {
+    checklist => [ __PACKAGE__, 'checklist', []],
+};
 
 1;
diff --git a/bin/Makefile b/bin/Makefile
index cfe81a22..aa5878c7 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -80,7 +80,7 @@ pve8to9.1:
 	 before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp
 	printf "Any failure must be addressed before the upgrade, and any warning must be addressed, \
 	 or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp
-	printf ".SH SYNOPSIS\npve8to9 [--full]\n" >> $@.tmp
+	printf ".SH SYNOPSIS\npve8to9 checklist [--full]\n" >> $@.tmp
 	mv $@.tmp $@
 
 pveversion.1.pod: pveversion
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-04-29 11:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 11:36 [pve-devel] [RFC storage/manager v3 0/6] fix #4997: lvm, lvm-thin: avoid autoactivating LVs Friedrich Weber
2025-04-29 11:36 ` [pve-devel] [PATCH pve-storage v3 1/3] lvm: create: use multiple lines for lvcreate command line Friedrich Weber
2025-04-29 11:36 ` [pve-devel] [PATCH pve-storage v3 2/3] fix #4997: lvm: create: disable autoactivation for new logical volumes Friedrich Weber
2025-04-29 11:36 ` [pve-devel] [PATCH pve-storage v3 3/3] lvmthin: " Friedrich Weber
2025-04-29 11:36 ` [pve-devel] [PATCH pve-manager stable-8 v3 1/3] cli: create pve8to9 script as a copy of pve7to8 Friedrich Weber
2025-04-29 11:36 ` Friedrich Weber [this message]
2025-04-29 11:36 ` [pve-devel] [PATCH pve-manager stable-8 v3 3/3] pve8to9: detect and (if requested) disable LVM autoactivation Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429113646.25738-6-f.weber@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal