From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback
Date: Mon, 28 Apr 2025 16:03:26 +0200 [thread overview]
Message-ID: <20250428140326.65005-1-s.shaji@proxmox.com> (raw)
The `onPopInvoked` callback is deprecated as of
Flutter v3.22.0-12.0.pre. This patch replaces it
with the `onPopInvokedWithResult` callback.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
lib/pages/main_layout_slim.dart | 2 +-
lib/states/pve_node_overview_state.dart | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
index 322bcac..8c4cacb 100644
--- a/lib/pages/main_layout_slim.dart
+++ b/lib/pages/main_layout_slim.dart
@@ -71,7 +71,7 @@ class _MainLayoutSlimState extends State<MainLayoutSlim> {
],
child: PopScope(
canPop: false,
- onPopInvoked: (didPop) async {
+ onPopInvokedWithResult: (didPop, _) {
if (didPop || pageSelector.value != 0) {
if (pageSelector.value != 0) pageSelector.add(0);
return;
diff --git a/lib/states/pve_node_overview_state.dart b/lib/states/pve_node_overview_state.dart
index 132764c..64353f8 100644
--- a/lib/states/pve_node_overview_state.dart
+++ b/lib/states/pve_node_overview_state.dart
@@ -1,5 +1,3 @@
-library pve_node_overview_state;
-
import 'package:built_collection/built_collection.dart';
import 'package:built_value/built_value.dart';
import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-04-28 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 14:03 Shan Shaji [this message]
2025-04-29 8:23 ` Shannon Sterz
2025-04-29 10:59 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428140326.65005-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal