public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] [PATCH pve_flutter_frontend] widgets: migrate from ButtonBar to OverflowBar
Date: Thu, 24 Apr 2025 18:25:19 +0200	[thread overview]
Message-ID: <20250424162519.259066-1-s.shaji@proxmox.com> (raw)

The `ButtonBar` widget has been deprecated as of Flutter
v3.21.0-10.0.pre. This patch replaces instance of `ButtonBar`
with `OverflowBar`.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 .../pve_task_log_expansiontile_widget.dart    | 40 +++++++++++--------
 1 file changed, 23 insertions(+), 17 deletions(-)

diff --git a/lib/widgets/pve_task_log_expansiontile_widget.dart b/lib/widgets/pve_task_log_expansiontile_widget.dart
index 6491b6b..ed4481b 100644
--- a/lib/widgets/pve_task_log_expansiontile_widget.dart
+++ b/lib/widgets/pve_task_log_expansiontile_widget.dart
@@ -119,24 +119,30 @@ class _PveTaskExpansionTileState extends State<PveTaskExpansionTile> {
           dense: true,
           subtitle: const Text('Shortlog'),
         ),
-        ButtonBar(
-          children: <Widget>[
-            if (widget.showMorePage != null)
+        Padding(
+          padding: const EdgeInsets.only(right: 8, bottom: 8),
+          child: OverflowBar(
+            alignment: MainAxisAlignment.end,
+            spacing: 8,
+            overflowAlignment: OverflowBarAlignment.end,
+            children: <Widget>[
+              if (widget.showMorePage != null)
+                OutlinedButton.icon(
+                  onPressed: () => Navigator.of(context).push(
+                      _createTaskLogRoute(taskLogBloc, widget.showMorePage)),
+                  icon: const Icon(Icons.format_list_bulleted),
+                  label: const Text('More Tasks'),
+                ),
               OutlinedButton.icon(
-                onPressed: () => Navigator.of(context).push(
-                    _createTaskLogRoute(taskLogBloc, widget.showMorePage)),
-                icon: const Icon(Icons.format_list_bulleted),
-                label: const Text('More Tasks'),
-              ),
-            OutlinedButton.icon(
-              onPressed: () => showTaskLogBottomSheet(context,
-                  taskLogBloc.apiClient, widget.task.node, widget.task.upid),
-              icon: const Icon(Icons.article),
-              label: const Text(
-                'Full Log',
-              ),
-            )
-          ],
+                onPressed: () => showTaskLogBottomSheet(context,
+                    taskLogBloc.apiClient, widget.task.node, widget.task.upid),
+                icon: const Icon(Icons.article),
+                label: const Text(
+                  'Full Log',
+                ),
+              )
+            ],
+          ),
         )
       ],
     );
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-04-24 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 16:25 Shan Shaji [this message]
2025-05-02  7:24 ` Michael Köppl
2025-05-07  7:50 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250424162519.259066-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal