public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files
@ 2025-04-24 10:54 Shan Shaji
  2025-04-24 12:15 ` Shannon Sterz
  0 siblings, 1 reply; 2+ messages in thread
From: Shan Shaji @ 2025-04-24 10:54 UTC (permalink / raw)
  To: pve-devel; +Cc: Shan Shaji

Omit `devtools_options.yaml` file and generated dart files
from source control.

`devtools_options.yaml` file is a config file for storing the
extension enablement states of flutter dev tools. By adding `devtools_options.yaml`
as an entry in the `.gitignore` file, the configurations will be seperate for each developer.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 3c88cc5..5e91008 100644
--- a/.gitignore
+++ b/.gitignore
@@ -43,3 +43,6 @@ app.*.map.json
 /android/app/debug
 /android/app/profile
 /android/app/release
+
+*.g.dart
+devtools_options.yaml
\ No newline at end of file
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files
  2025-04-24 10:54 [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files Shan Shaji
@ 2025-04-24 12:15 ` Shannon Sterz
  0 siblings, 0 replies; 2+ messages in thread
From: Shannon Sterz @ 2025-04-24 12:15 UTC (permalink / raw)
  To: Proxmox VE development discussion; +Cc: Shan Shaji, pve-devel

On Thu Apr 24, 2025 at 12:54 PM CEST, Shan Shaji wrote:
> Omit `devtools_options.yaml` file and generated dart files
> from source control.
>
> `devtools_options.yaml` file is a config file for storing the
> extension enablement states of flutter dev tools. By adding `devtools_options.yaml`
> as an entry in the `.gitignore` file, the configurations will be seperate for each developer.

just a small nit, the two lines above are longer than the 72 characters
suggested by our commit message style guide [1]. please make sure that
whatever editor you use enforce the hard line wrapping here correctly :)

[1]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 3c88cc5..5e91008 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -43,3 +43,6 @@ app.*.map.json
>  /android/app/debug
>  /android/app/profile
>  /android/app/release
> +
> +*.g.dart
> +devtools_options.yaml
> \ No newline at end of file



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-24 12:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-24 10:54 [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files Shan Shaji
2025-04-24 12:15 ` Shannon Sterz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal