[pve-devel] [RFC storage 0/3] rbd: use image-/snap-spec instead of --pool/..

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

the 'rbd' CLI tool has two ways of specifying which images/snapshots to
operate on:
- the deprecated --(dest-)pool, --namespace, --image and --snap parameters
- the new style 'spec'-based variant, passing [pool/[namespace/]]image[@snapshot]

we are currently using a mix of both (passing pool, namespace and snap
as needed via parameters, and the image-name as argument). this patch
series switches everything to use image or snap specs, except for `ls`,
which can't be switched over, because it doesn't operate on images at
all.

`unmap` doesn't support `--namespace` (but doesn't need it, since it
takes the kernel dev as argument). `import` doesn't either, but does
require it when a namespace is used as import target (this bug prompted
the whole excursion resulting in this patch series).

I smoke-tested the changes, but it's possible I missed some operation or
corner case when converting, so additional testing is highly
appreciated.

Fabian Grünbichler (3):
  rbd: extend get_rbd_(dev_)path helpers with $snap parameter
  fix #6338: rbd: use image-/snap-spec consistently
  rbd: add protect/unprotect helpers

 src/PVE/Storage/RBDPlugin.pm | 167 ++++++++++++++++++-----------------
 1 file changed, 86 insertions(+), 81 deletions(-)

-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel