From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager v2 1/1] qemu: network: adjust MTU emptyText to match new default behavior
Date: Thu, 17 Apr 2025 12:48:54 +0200 [thread overview]
Message-ID: <20250417104855.144882-3-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250417104855.144882-1-s.hanreich@proxmox.com>
Leaving the MTU field unset now defaults to the bridge MTU, rather
than 1500. Reflect this change by indicating the new behavior in the
emptyText of the MTU field. While we're at it, add a gettext call so
it can be translated. I've taken the same text as from the container
dialogue, so it should already use existing translations.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
www/manager6/qemu/NetworkEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index 4917eba5f..5e7ed22d1 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -113,7 +113,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
disabled: '{!isVirtio}',
value: '{mtu}',
},
- emptyText: '1500 (1 = bridge MTU)',
+ emptyText: gettext('Same as bridge'),
minValue: 1,
maxValue: 65520,
allowBlank: true,
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-17 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 10:48 [pve-devel] [PATCH docs/manager/qemu-server v2 0/3] Make VirtIO network devices always inherit MTU from bridge Stefan Hanreich
2025-04-17 10:48 ` [pve-devel] [PATCH qemu-server v2 1/1] net: pass host_mtu parameter when mtu is unset in netdev config Stefan Hanreich
2025-04-17 10:48 ` Stefan Hanreich [this message]
2025-04-17 10:48 ` [pve-devel] [PATCH pve-docs v2 1/1] qm: document new default behavior for mtu setting Stefan Hanreich
2025-04-18 7:46 ` [pve-devel] [PATCH docs/manager/qemu-server v2 0/3] Make VirtIO network devices always inherit MTU from bridge Thomas Lamprecht
2025-04-22 11:33 ` Stefan Hanreich
2025-04-22 14:48 ` Thomas Lamprecht
2025-04-23 11:52 ` Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417104855.144882-3-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal