public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH docs/proxmox-firewall 0/3] migrate proxmox-firewall to proxmox-log + introduce subcommands
Date: Mon, 14 Apr 2025 17:44:52 +0200	[thread overview]
Message-ID: <20250414154455.274151-1-s.hanreich@proxmox.com> (raw)

Since we now have proxmox-log as the standard crate for logging purposes,
migrate proxmox-firewall to the new logging crate.

The old logging setup was also tied with the debugging mechanisms described in
the documentation. I used that opportunity to implement specific subcommands for
debugging proxmox-firewall, instead of just relying solely on the log output.

The patch for changing to proxmox-log can be applied independently, but this
breaks the commands included in the documentation. That's why I decided to send
them as part of one patch series, because the change to proxmox-log prompted me
to implement the subcommands for debugging in the first place.

proxmox-firewall:

Stefan Hanreich (2):
  firewall: use proxmox_log
  firewall: add subcommands to proxmox-firewall binary

 debian/control                               |   4 +-
 debian/proxmox-firewall.service              |   4 +-
 proxmox-firewall/Cargo.toml                  |   5 +-
 proxmox-firewall/src/bin/proxmox-firewall.rs | 124 ++++++++++++++-----
 proxmox-firewall/src/config.rs               |   2 +
 proxmox-firewall/src/firewall.rs             |   2 +
 proxmox-firewall/src/object.rs               |   2 +
 proxmox-firewall/src/rule.rs                 |   2 +
 8 files changed, 110 insertions(+), 35 deletions(-)


pve-docs:

Stefan Hanreich (1):
  firewall: update 'useful commands' section with new subcommands

 pve-firewall.adoc | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)


Summary over all repositories:
  9 files changed, 134 insertions(+), 49 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-04-14 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 15:44 Stefan Hanreich [this message]
2025-04-14 15:44 ` [pve-devel] [PATCH proxmox-firewall 1/2] firewall: use proxmox_log Stefan Hanreich
2025-04-14 15:44 ` [pve-devel] [PATCH proxmox-firewall 2/2] firewall: add subcommands to proxmox-firewall binary Stefan Hanreich
2025-04-23 11:46   ` Gabriel Goller
2025-04-14 15:44 ` [pve-devel] [PATCH pve-docs 1/1] firewall: update 'useful commands' section with new subcommands Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250414154455.274151-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal