public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config
Date: Tue,  8 Apr 2025 18:32:49 +0200	[thread overview]
Message-ID: <20250408163250.355449-2-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250408163250.355449-1-s.hanreich@proxmox.com>

Since we now ship frr with Proxmox VE, the frr service is available on
the nodes but disabled on install. Prior to that users had to manually
install frr, which automatically enabled the service. When applying a
SDN configuration with an EVPN controller, we invoke systemctl restart
frr, which leads to the service running but still being in the
disabled state. This means that the EVPN setup is working until the
next reboot. To avoid the situation where users configure an EVPN
controller and everything seems to be working, until a restart breaks
the EVPN setup, additionally enable the frr service before restarting
it.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
index c245ea2..4249cc5 100644
--- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
+++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
@@ -638,6 +638,7 @@ sub reload_controller {
 	};
 	if ($@) {
 	    warn "frr reload command fail. Restarting frr.";
+	    run_command(['systemctl', 'enable', 'frr']);
 	    eval { run_command(['systemctl', 'restart', 'frr']); };
 	}
     }
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-08 16:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 16:32 [pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed Stefan Hanreich
2025-04-08 16:32 ` Stefan Hanreich [this message]
2025-04-08 18:43   ` [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config Thomas Lamprecht
2025-04-08 19:39     ` Stefan Hanreich
2025-04-08 19:42     ` Stoiko Ivanov
2025-04-08 19:46       ` Stefan Hanreich
2025-04-08 16:32 ` [pve-devel] [PATCH pve-docs 1/1] sdn: frr update documentation for installing frr package Stefan Hanreich
2025-04-08 16:59 ` [pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed Stefan Hanreich
2025-04-08 17:07 ` Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250408163250.355449-2-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal