public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options
Date: Tue,  8 Apr 2025 15:25:17 +0200	[thread overview]
Message-ID: <20250408132517.225240-1-s.hanreich@proxmox.com> (raw)

The hostname provided to the methods in the IPAM plugins is empty for
VMs that do not have a name set. We always included the dns_name key
in the request, even if it was undefined, which leads Netbox to return
a 400 Bad Request error. With this patch we omit the dns_name
parameter if it isn't set, so the call succeeds.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 36 +++++++++++++++--------
 1 file changed, 24 insertions(+), 12 deletions(-)

diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
index a691323..97a0c3f 100644
--- a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
+++ b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
@@ -206,11 +206,14 @@ sub add_ip {
     }
 
     eval {
-	netbox_api_request($plugin_config, "POST", "/ipam/ip-addresses/", {
+	my $params = {
 	    address => "$ip/$mask",
-	    dns_name => $hostname,
 	    description => $description,
-	});
+	};
+
+	$params->{dns_name} = $hostname if $hostname;
+
+	netbox_api_request($plugin_config, "POST", "/ipam/ip-addresses/", $params);
     };
 
     if ($@) {
@@ -244,11 +247,14 @@ sub update_ip {
     }
 
     eval {
-	netbox_api_request($plugin_config, "PATCH", "/ipam/ip-addresses/$ip_id/", {
+	my $params = {
 	    address => "$ip/$mask",
-	    dns_name => $hostname,
 	    description => $description,
-	});
+	};
+
+	$params->{dns_name} = $hostname if $hostname;
+
+	netbox_api_request($plugin_config, "PATCH", "/ipam/ip-addresses/$ip_id/", $params);
     };
     if ($@) {
 	die "error update ip $ip : $@" if !$noerr;
@@ -272,10 +278,13 @@ sub add_next_freeip {
     $description = "mac:$mac" if $mac;
 
     my $ip = eval {
-	my $result = netbox_api_request($plugin_config, "POST", "/ipam/prefixes/$internalid/available-ips/", {
-	    dns_name => $hostname,
+	my $params = {
 	    description => $description,
-	});
+	};
+
+	$params->{dns_name} = $hostname if $hostname;
+
+	my $result = netbox_api_request($plugin_config, "POST", "/ipam/prefixes/$internalid/available-ips/", $params);
 
 	my ($ip, undef) = split(/\//, $result->{address});
 	return $ip;
@@ -303,10 +312,13 @@ sub add_range_next_freeip {
     $description = "mac:$data->{mac}" if $data->{mac};
 
     my $ip = eval {
-	my $result = netbox_api_request($plugin_config, "POST", "/ipam/ip-ranges/$internalid/available-ips/", {
-	    dns_name => $data->{hostname},
+	my $params = {
 	    description => $description,
-	});
+	};
+
+	$params->{dns_name} = $data->{hostname} if $data->{hostname};
+
+	my $result = netbox_api_request($plugin_config, "POST", "/ipam/ip-ranges/$internalid/available-ips/", $params);
 
 	my ($ip, undef) = split(/\//, $result->{address});
 	print "found ip free $ip in range $range->{'start-address'}-$range->{'end-address'}\n" if $ip;
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-04-08 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 13:25 Stefan Hanreich [this message]
2025-04-08 13:29 ` Thomas Lamprecht
2025-04-08 13:32   ` Stefan Hanreich
2025-04-08 13:37 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250408132517.225240-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal