[pve-devel] [PATCH installer v2] auto: add some error context when loading first-boot executable

[pve-devel] [PATCH installer v2] auto: add some error context when loading first-boot executable

[Christoph Heiss]

At least to one user in the forum already ran into this IIRC, and most
recently Maximiliano too.

This can happen when e.g. copying example answer files with the
first-boot section, without then passing `--on-first-boot` to
proxmox-auto-install-assistant.

In that case, the user would just get a pretty unhelpful error message:

  ERROR: Autoinstaller setup error: No such file or directory (os error 2)

Attach some context, which points the user directly to the corresponding
setting / answer file section.

Reported-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxmox-auto-installer/src/bin/proxmox-auto-installer.rs | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/proxmox-auto-installer/src/bin/proxmox-auto-installer.rs b/proxmox-auto-installer/src/bin/proxmox-auto-installer.rs
index 05d1801..a42029f 100644
--- a/proxmox-auto-installer/src/bin/proxmox-auto-installer.rs
+++ b/proxmox-auto-installer/src/bin/proxmox-auto-installer.rs
@@ -1,4 +1,4 @@
-use anyhow::{Result, bail, format_err};
+use anyhow::{Context, Result, bail, format_err};
 use log::{LevelFilter, error, info};
 use std::{
     env,
@@ -47,7 +47,9 @@ fn setup_first_boot_executable(first_boot: &FirstBootHookInfo) -> Result<()> {
             }
         }
         FirstBootHookSourceMode::FromIso => {
-            Some(fs::read(format!("/cdrom/{FIRST_BOOT_EXEC_NAME}"))?)
+            let content = fs::read(format!("/cdrom/{FIRST_BOOT_EXEC_NAME}"))
+                .context("failed loading first-boot executable from ISO (was ISO prepared with `--on-first-boot` specified?)")?;
+            Some(content)
         }
     };
 
@@ -115,7 +117,7 @@ fn main() -> ExitCode {
     let (answer, udevadm_info) = match auto_installer_setup(in_test_mode) {
         Ok(result) => result,
         Err(err) => {
-            error!("Autoinstaller setup error: {err}");
+            error!("Autoinstaller setup error: {err:?}");
             return ExitCode::FAILURE;
         }
     };
-- 
2.48.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH installer v2] auto: add some error context when loading first-boot executable

[Thomas Lamprecht]

On Tue, 08 Apr 2025 11:54:43 +0200, Christoph Heiss wrote:
> At least to one user in the forum already ran into this IIRC, and most
> recently Maximiliano too.
> 
> This can happen when e.g. copying example answer files with the
> first-boot section, without then passing `--on-first-boot` to
> proxmox-auto-install-assistant.
> 
> [...]

Applied, thanks!

[1/1] auto: add some error context when loading first-boot executable
      commit: 9143452ddb3aac2d3901876a1f27f6354fa891ab


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel