[pve-devel] [PATCH qemu-server, manager v5 0/4] fix #1926 autodetect xtermjs or novnc for VM console

[Aaron Lauterer <a.lauterer@proxmox.com>]

This version 5 of the series uses a  different approach as discussed [0] in
the last interation.
We add a new property in the VM status/current API result that includes
the display configurtion of the VM. This way we can check in the
frontend what to do with it.

I chose a nested return value, as that makes it easier to add/move
additional display properties into it.

The first patch just adds the serial property to the API docs as it was
missing. So not really related to this series, but I came across it.


Patch 2/4 adds the new display property. If not explicitly set in the VM
config, it will return the default 'std' value.

Patch 3/4 implements the changes in the UI. The final result isn't
really a lot simpler on the UI side than in V4 where we had the extra
API call to the VM's config directly. Because we still need to wait for
the API call to finish when initially navigating to the VM. But we have
one fewer call.

Patch 4/4 then introduces some changes to make loading of the console
faster if we just navigate in the submenu of a VM itself where we
already have the current status of a VM already cached.

[0] https://lore.proxmox.com/pve-devel/49bcd58f-aba2-4c1e-a6a0-d21828a335bf@proxmox.com/

qemu-server: Aaron Lauterer (2):
  vmstatus_return_properties: add missing serial property
  api: status/current: add display property

 PVE/API2/Qemu.pm  | 13 +++++++++++++
 PVE/QemuServer.pm |  5 +++++
 2 files changed, 18 insertions(+)


manager: Aaron Lauterer (2):
  fix #1926 ui: vm console: autodetect novnc or xtermjs
  ui: console: check on activate if display info for VMs is present

 www/manager6/VNCConsole.js  | 60 ++++++++++++++++++++++++++-----------
 www/manager6/qemu/Config.js |  8 ++++-
 2 files changed, 50 insertions(+), 18 deletions(-)

-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel