public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-guest-common] replication: delete job even if it is disabled
@ 2025-04-07  8:51 Hannes Laimer
  2025-04-07 12:04 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2025-04-07  8:51 UTC (permalink / raw)
  To: pve-devel

Currently we skip all disabled jobs, also the ones up for deletion,
which does not make sense. This came up in support.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/PVE/ReplicationState.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/ReplicationState.pm b/src/PVE/ReplicationState.pm
index 16b3d90..e91b6fc 100644
--- a/src/PVE/ReplicationState.pm
+++ b/src/PVE/ReplicationState.pm
@@ -272,7 +272,7 @@ sub job_status {
 	    # never sync to local node
 	    next if !$jobcfg->{remove_job} && $target eq $local_node;
 
-	    next if !$get_disabled && $jobcfg->{disable};
+	    next if !$jobcfg->{remove_job} && !$get_disabled && $jobcfg->{disable};
 
 	    my $state = extract_job_state($stateobj, $jobcfg);
 	    $jobcfg->{state} = $state;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-07 12:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-07  8:51 [pve-devel] [PATCH pve-guest-common] replication: delete job even if it is disabled Hannes Laimer
2025-04-07 12:04 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal