From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-guest-common] replication: delete job even if it is disabled
Date: Mon, 7 Apr 2025 10:51:38 +0200 [thread overview]
Message-ID: <20250407085138.4653-1-h.laimer@proxmox.com> (raw)
Currently we skip all disabled jobs, also the ones up for deletion,
which does not make sense. This came up in support.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/PVE/ReplicationState.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/ReplicationState.pm b/src/PVE/ReplicationState.pm
index 16b3d90..e91b6fc 100644
--- a/src/PVE/ReplicationState.pm
+++ b/src/PVE/ReplicationState.pm
@@ -272,7 +272,7 @@ sub job_status {
# never sync to local node
next if !$jobcfg->{remove_job} && $target eq $local_node;
- next if !$get_disabled && $jobcfg->{disable};
+ next if !$jobcfg->{remove_job} && !$get_disabled && $jobcfg->{disable};
my $state = extract_job_state($stateobj, $jobcfg);
$jobcfg->{state} = $state;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-04-07 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 8:51 Hannes Laimer [this message]
2025-04-07 12:04 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407085138.4653-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal