From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit v3 1/1] close #3181: ui: add formatted guest identifier to safe destroy dialog window
Date: Mon, 7 Apr 2025 10:38:05 +0200 [thread overview]
Message-ID: <20250407083806.63773-2-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250407083806.63773-1-m.koeppl@proxmox.com>
Adds a formatted guest identifier (e.g. "VMID (VM name)") to the
SafeDestroy window. The formatted identifier is only used if it is
explicitly set by the caller. Otherwise, the VMID is used, avoiding
changes in behavior for other components.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/window/SafeDestroy.js | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index fad7897..1505870 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -26,6 +26,7 @@ Ext.define('Proxmox.window.SafeDestroy', {
config: {
item: {
id: undefined,
+ formattedIdentifier: undefined,
},
url: undefined,
note: undefined,
@@ -189,7 +190,12 @@ Ext.define('Proxmox.window.SafeDestroy', {
let taskName = me.getTaskName();
if (Ext.isDefined(taskName)) {
me.lookupReference('messageCmp').setHtml(
- Ext.htmlEncode(Proxmox.Utils.format_task_description(taskName, itemId)),
+ Ext.htmlEncode(
+ Proxmox.Utils.format_task_description(
+ taskName,
+ me.getItem().formattedIdentifier ?? itemId,
+ ),
+ ),
);
} else {
throw "no task name specified";
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 8:38 [pve-devel] [PATCH manager/widget-toolkit v3 0/2] close #3181: ui: display guest name in confirm dialogs Michael Köppl
2025-04-07 8:38 ` Michael Köppl [this message]
2025-04-07 12:05 ` [pve-devel] applied: [PATCH widget-toolkit v3 1/1] close #3181: ui: add formatted guest identifier to safe destroy dialog window Thomas Lamprecht
2025-04-07 8:38 ` [pve-devel] [PATCH manager v3 1/1] close #3181: ui: display guest name in confirm dialogs Michael Köppl
2025-04-07 12:16 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407083806.63773-2-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal