public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu-server 3/4] migration: drop deprecated 'zero-blocks' capability
Date: Mon,  7 Apr 2025 09:32:55 +0200	[thread overview]
Message-ID: <20250407073256.8889-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250407073256.8889-1-f.ebner@proxmox.com>

The 'zero-blocks' capability was deprecated in QEMU commit 73581a041e
("migration: Deprecate zero-blocks capability")

> The zero-blocks capability was meant to be used along with the block
> migration, which has been removed already in commit eef0bae3a7
> ("migration: Remove block migration").

> Setting zero-blocks is currently a noop, but the outright removal of
> the capability would cause and error in case some users are still
> setting it. Put the capability through the deprecation process.

The default for the capability already was disabled (checked in QEMU
8.0 source).

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index cef6d068..65045500 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4616,7 +4616,6 @@ sub set_migration_caps {
 	"auto-converge" => 1,
 	"xbzrle" => 1,
 	"x-rdma-pin-all" => 0,
-	"zero-blocks" => 0,
 	"dirty-bitmaps" => $dirty_bitmaps,
     };
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-04-07  7:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  7:32 [pve-devel] [PATCH-SERIES v2 qemu-server 0/4] QEMU 9.2 compat Fiona Ebner
2025-04-07  7:32 ` [pve-devel] [PATCH v2 qemu-server 1/4] cfg2cmd: replace deprecated 'reconnect' option with 'reconnect-ms' Fiona Ebner
2025-04-07  7:32 ` [pve-devel] [PATCH v2 qemu-server 2/4] migration: drop removed 'compress' capability Fiona Ebner
2025-04-07  7:32 ` Fiona Ebner [this message]
2025-04-07  7:32 ` [pve-devel] [PATCH v2 qemu-server 4/4] migration: remove wrong attempt of disabling 'rdma-pin-all' capability Fiona Ebner
2025-04-07  7:54 ` [pve-devel] applied: [PATCH-SERIES v2 qemu-server 0/4] QEMU 9.2 compat Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407073256.8889-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal