public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/3] fix #6285: always set up zfs modprobe configuration
Date: Fri,  4 Apr 2025 14:46:45 +0200	[thread overview]
Message-ID: <20250404124651.1283950-1-c.heiss@proxmox.com> (raw)

Fixes #6285 [0].

This also came up quite a few times already in the forum, most recently
[1] (german).

Since we do expose the option in the UI for all products nowadays (on
ZFS-on-root installations only tho), just always write to
/etc/modprobe.d/zfs.conf.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=6285
[1] https://forum.proxmox.com/threads/ram-auslastung-nimmt-%C3%BCber-die-zeit-drastisch-zu.164527/#post-760989

Testing
=======

Tested for each product PVE, PBS, PMG the following
  - install on ZFS, not touching the ARC size setting
  - install on ZFS, set some explicit value for ARC size
  - installing on non-ZFS such as ext4

.. and checking afterwards that /etc/modprobe.d/zfs.conf was written and
contained respectively
  - the default value for the product
  - the set value
  - again the default value for the product

Also tested each case with the auto-installer for PVE and PMG.

Diffstat
========

Christoph Heiss (3):
  run env: always return proper value for default zfs max arc size
  tui: bootdisk: always return proper value for default zfs max arc size
  fix #6285: install: always set up zfs modprobe configuration

 Proxmox/Install.pm                          | 11 +++---
 Proxmox/Install/RunEnv.pm                   |  9 +++--
 proxmox-tui-installer/src/views/bootdisk.rs | 32 +++++++++-------
 test/zfs-arc-max.pl                         | 42 +++++++++++++--------
 4 files changed, 57 insertions(+), 37 deletions(-)

-- 
2.48.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-04-04 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 12:46 Christoph Heiss [this message]
2025-04-04 12:46 ` [pve-devel] [PATCH installer 1/3] run env: always return proper value for default zfs max arc size Christoph Heiss
2025-04-04 12:46 ` [pve-devel] [PATCH installer 2/3] tui: bootdisk: " Christoph Heiss
2025-04-04 12:46 ` [pve-devel] [PATCH installer 3/3] fix #6285: install: always set up zfs modprobe configuration Christoph Heiss
2025-04-04 13:01 ` [pve-devel] applied-series: [PATCH installer 0/3] fix #6285: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404124651.1283950-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal