public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH follow-up qemu-server] api: migrate preconditions: add schema description for 'mapped-resource-info'
Date: Thu,  3 Apr 2025 16:19:48 +0200	[thread overview]
Message-ID: <20250403141948.4149551-1-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250311132055.2826686-9-d.csapak@proxmox.com>

Since it's an object that has the config-properties as keys (e.g.
hostpci0), we have to add all possible values (hostpciX/usbX) to it as
optional, like we do for e.g. config GET api calls.

The actual info per property is not much currently, just the name of
the mapping and for PCI devices if they're marked as live-migratable.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this is a follow-up for:
[PATCH qemu-server v7 6/9] api: enable live migration for marked mapped pci devices
https://lore.proxmox.com/pve-devel/20250311132055.2826686-9-d.csapak@proxmox.com/

could also be squashed in on applying if wanted

 PVE/API2/Qemu.pm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 459c7e29..a2e200c7 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -4580,6 +4580,46 @@ my $check_vm_disks_local = sub {
     return $local_disks;
 };
 
+sub mapped_resource_info_properties {
+    my $properties= {};
+
+    for (my $i = 0; $i < $PVE::QemuServer::PCI::MAX_HOSTPCI_DEVICES; $i++) {
+	$properties->{"hostpci$i"} = {
+	    type => 'object',
+	    description => "Information about hostpci$i",
+	    optional => 1,
+	    properties => {
+		name => {
+		    type => 'string',
+		    description => 'The name of the mapping.',
+		},
+		'live-migration' => {
+		    type => 'boolean',
+		    optional => 1,
+		    default => 0,
+		    description => "True if the mapping is marked as live-migration capable.",
+		},
+	    },
+	};
+    }
+
+    for (my $i = 0; $i < $PVE::QemuServer::USB::MAX_USB_DEVICES; $i++) {
+	$properties->{"usb$i"} = {
+	    type => 'object',
+	    description => "Information about usb$i",
+	    optional => 1,
+	    properties => {
+		name => {
+		    type => 'string',
+		    description => 'The name of the mapping.',
+		},
+	    },
+	};
+    }
+
+    return $properties;
+}
+
 __PACKAGE__->register_method({
     name => 'migrate_vm_precondition',
     path => '{vmid}/migrate',
@@ -4681,6 +4721,7 @@ __PACKAGE__->register_method({
 	    'mapped-resource-info' => {
 		type => 'object',
 		description => "Object of mapped resources with additional information such if they're live migratable.",
+		properties => mapped_resource_info_properties(),
 	    },
 	},
     },
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-04-03 14:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 13:20 [pve-devel] [PATCH guest-common/qemu-server/manager/docs v7] implement experimental vgpu live migration Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH guest-common v7 1/2] mapping: pci: check the mdev configuration on the device too Dominik Csapak
2025-04-03  9:40   ` Thomas Lamprecht
2025-04-03  9:43     ` Dominik Csapak
2025-04-03  9:44       ` Thomas Lamprecht
2025-03-11 13:20 ` [pve-devel] [PATCH guest-common v7 2/2] mapping: pci: add 'live-migration-capable' flag to mappings Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 1/9] tests: cfg2cmd: fix mdev tests Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 2/9] pci: mapping: check mdev config against hardware Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 3/9] pci: set 'enable-migration' to on for live-migration marked mapped devices Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 4/9] check_local_resources: add more info per mapped device and return as hash Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 5/9] check_local_resources: allow mapped devices for offline migration Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 6/9] api: enable live migration for marked mapped pci devices Dominik Csapak
2025-04-03 13:00   ` Thomas Lamprecht
2025-04-03 13:07     ` Dominik Csapak
2025-04-03 14:19   ` Dominik Csapak [this message]
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 7/9] api: include not mapped resources for running vms in migrate preconditions Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 8/9] migrate: show vfio state transferred too Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 9/9] migrate: add transfer summary Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 1/4] mapping: pci: include mdev in config checks Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 2/4] bulk migrate: improve precondition checks Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 3/4] ui: adapt migration window to precondition api change Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 4/4] fix #5175: ui: allow configuring and live migration of mapped pci resources Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH docs v7 1/2] qm: resource mapping: add description for `mdev` option Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH docs v7 2/2] qm: resource mapping: document `live-migration-capable` setting Dominik Csapak
2025-04-01  9:18 ` [pve-devel] [PATCH guest-common/qemu-server/manager/docs v7] implement experimental vgpu live migration Dominik Csapak
2025-04-01 13:17 ` Christoph Heiss
2025-04-03 16:33 ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250403141948.4149551-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal