From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2] ui: lxc: set nesting to false for privileged container during creation
Date: Fri, 21 Mar 2025 11:35:11 +0100 [thread overview]
Message-ID: <20250321103511.66722-1-m.koeppl@proxmox.com> (raw)
The current implementation is slightly misleading. When creating a
privileged container, the nesting checkbox is disabled but keeps its
current state. However, nesting is not enabled for privileged containers
even if the checkbox was set to true. With this change, the nesting
checkbox is set to its unchecked state whenever it is disabled by
switching to privileged container creation, making clear that the
nesting feature will not be enabled.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
Changes from v1 to v2:
- Use existing clearOnDisable property instead of data binding and listeners
www/manager6/lxc/CreateWizard.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 62cda27a..4ec192c0 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -75,6 +75,7 @@ Ext.define('PVE.lxc.CreateWizard', {
name: 'features',
inputValue: 'nesting=1',
value: true,
+ clearOnDisable: true,
bind: {
disabled: '{!unprivileged}',
},
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-03-21 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 10:35 Michael Köppl [this message]
2025-03-24 11:29 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321103511.66722-1-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal