public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog
Date: Tue,  4 Mar 2025 11:49:54 +0100	[thread overview]
Message-ID: <20250304104954.191259-1-m.sandoval@proxmox.com> (raw)

Whenever a filesystem is selected we show the size selection stack page.

At the moment entering any raid setup, then entering the Advanced
Options page and then selecting any non-raid setup will show the
raiddisk page since it is still the visible child.

Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxinstall b/proxinstall
index fe7e29f..5e61e9b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1358,6 +1358,7 @@ sub create_hdoption_view {
 	    $options_stack->set_visible_child_name("raiddisk");
 	} else {
 	    $target_hd_label->set_text("Target Harddisk");
+	    $options_stack->set_visible_child_name("hdsize");
 	}
 
 	if ($raid) {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-03-04 10:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 10:49 Maximiliano Sandoval [this message]
2025-03-19  8:30 ` Maximiliano Sandoval
2025-03-19 10:15 ` Christoph Heiss
2025-04-01 13:09   ` Maximiliano Sandoval
2025-04-04  8:31     ` Thomas Lamprecht
2025-04-04  8:40       ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304104954.191259-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal