public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] grub: set debconf value to indicate --removable install
Date: Tue,  4 Mar 2025 10:45:22 +0100	[thread overview]
Message-ID: <20250304094522.1621953-1-f.gruenbichler@proxmox.com> (raw)

else we risk that the fallback boot manager and the rest of the Grub components
in /boot run out of sync, which can break booting on systems that use that
fallback entry instead of the regular one..

this debconf variable is read by grub-efi-amd64 and shim(-signed) postinst
script, if set, `--force-extra-removable` gets passed to their grub-install
invocations.

Reported on the forum: https://forum.proxmox.com/threads/162989

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Reproduced by installing using the 8.0 iso, switching over to grub-efi-amd64
and attempting to boot the fallback entry instead of the 'proxmox' one.

Setting the debconf value before installing grub-efi-amd64 makes it all work
as expected.

 Proxmox/Install.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c0a17b2..57fd899 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1206,6 +1206,7 @@ postfix postfix/main_mailer_type select No configuration
 keyboard-configuration keyboard-configuration/xkb-keymap select $xkmap
 d-i debian-installer/locale select en_US.UTF-8
 grub-pc grub-pc/install_devices select $grub_install_devices_txt
+grub-efi-amd64 grub2/force_efi_extra_removable boolean true
 _EOD
 
 	my $pkg_count = 0;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

             reply	other threads:[~2025-03-04  9:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04  9:45 Fabian Grünbichler [this message]
2025-03-04 10:52 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304094522.1621953-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal