From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC manager 2/3] fix #6094: api: node HW: allow to get usb info with Sys.Audit on /
Date: Mon, 17 Feb 2025 13:19:17 +0100 [thread overview]
Message-ID: <20250217121918.117810-3-d.kral@proxmox.com> (raw)
In-Reply-To: <20250217121918.117810-1-d.kral@proxmox.com>
Relax the required permissions to query the current list of locally
available USB devices. The API endpoint does only read the USB topology
from the sysfs but does not modify any system state.
Keep Sys.Modify for backwards compatibility.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
PVE/API2/Hardware/USB.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Hardware/USB.pm b/PVE/API2/Hardware/USB.pm
index d7cb6607..049d1170 100644
--- a/PVE/API2/Hardware/USB.pm
+++ b/PVE/API2/Hardware/USB.pm
@@ -17,7 +17,7 @@ __PACKAGE__->register_method({
protected => 1,
proxyto => "node",
permissions => {
- check => ['perm', '/', ['Sys.Modify']],
+ check => ['perm', '/', [ 'Sys.Audit', 'Sys.Modify' ], any => 1],
},
parameters => {
additionalProperties => 0,
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-17 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 12:19 [pve-devel] [RFC manager 0/3] #fix 6094: relax permissions of informational api endpoints Daniel Kral
2025-02-17 12:19 ` [pve-devel] [RFC manager 1/3] fix #6094: api: apt: allow to get packages info with Sys.Audit Daniel Kral
2025-05-06 13:52 ` Fiona Ebner
2025-02-17 12:19 ` Daniel Kral [this message]
2025-05-06 13:52 ` [pve-devel] [RFC manager 2/3] fix #6094: api: node HW: allow to get usb info with Sys.Audit on / Fiona Ebner
2025-02-17 12:19 ` [pve-devel] [RFC manager 3/3] fix #6094: api: acme: allow to get plugin " Daniel Kral
2025-05-06 13:52 ` Fiona Ebner
2025-05-07 9:15 ` Fabian Grünbichler
2025-05-07 9:43 ` Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217121918.117810-3-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal