From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC v2 storage 08/10] rbd plugin: volume exists helper: distinguish between different errors
Date: Tue, 17 Dec 2024 16:48:12 +0100 [thread overview]
Message-ID: <20241217154814.82121-9-f.ebner@proxmox.com> (raw)
In-Reply-To: <20241217154814.82121-1-f.ebner@proxmox.com>
Only claim that the image does not exist if the error message
indicates it.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
If we don't want to match the error, I'll switch the helper over to
list volumes and check there.
New in v2.
src/PVE/Storage/RBDPlugin.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index 0e53888..004842b 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -355,7 +355,11 @@ my sub rbd_volume_exists {
my $cmd = $rbd_cmd->($scfg, $storeid, 'info', $volname);
run_rbd_command($cmd, errmsg => "exist check", quiet => 1);
};
- return $@ ? undef : 1;
+ if (my $err = $@) {
+ return if $err =~ m/No such file or directory$/;
+ die $err;
+ }
+ return 1;
}
# Configuration
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-17 15:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 15:48 [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 01/10] iscsi direct plugin: fix return value for path() method in non-array context Fiona Ebner
2024-12-18 13:39 ` Fiona Ebner
2024-12-18 13:43 ` Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 02/10] rbd plugin: schema: document default value for 'krbd' setting Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 03/10] export: redirect stdout to avoid any unrelated messages ending up in the export stream Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 04/10] rbd plugin: factor out helper to check if volume already exists Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 05/10] rbd plugin: implement volume import/export Fiona Ebner
2024-12-18 14:20 ` Daniel Kral
2024-12-18 15:14 ` Fiona Ebner
2024-12-18 15:33 ` DERUMIER, Alexandre via pve-devel
2024-12-19 8:56 ` Fiona Ebner
2024-12-19 10:43 ` DERUMIER, Alexandre via pve-devel
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 06/10] iscsi plugin: support volume export Fiona Ebner
2024-12-18 14:05 ` Filip Schauer
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 07/10] iscsi direct " Fiona Ebner
2024-12-18 14:07 ` Filip Schauer
2024-12-17 15:48 ` Fiona Ebner [this message]
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 09/10] common: introduce common module Fiona Ebner
2024-12-18 9:36 ` Max Carrara
2024-12-18 9:41 ` Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 10/10] plugins: volume import: align size up to 1KiB Fiona Ebner
2024-12-18 10:34 ` [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages Fiona Ebner
2024-12-18 14:08 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217154814.82121-9-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox