* [pve-devel] [Typo corrected. 0/2] *** Corrections *** @ 2024-12-17 10:11 Alexander Abraham 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 1/2] Section on ZFS and swap corrected Alexander Abraham 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos Alexander Abraham 0 siblings, 2 replies; 4+ messages in thread From: Alexander Abraham @ 2024-12-17 10:11 UTC (permalink / raw) To: pve-devel; +Cc: Alexander Abraham *** Broke down a long sentence and fixed some typos. *** Alexander Abraham (2): Section on ZFS and swap corrected. Split a long sentence and corrected some typos. local-zfs.adoc | 37 ++----------------------------------- 1 file changed, 2 insertions(+), 35 deletions(-) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [Typo corrected. 1/2] Section on ZFS and swap corrected. 2024-12-17 10:11 [pve-devel] [Typo corrected. 0/2] *** Corrections *** Alexander Abraham @ 2024-12-17 10:11 ` Alexander Abraham 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos Alexander Abraham 1 sibling, 0 replies; 4+ messages in thread From: Alexander Abraham @ 2024-12-17 10:11 UTC (permalink / raw) To: pve-devel; +Cc: Alexander Abraham --- local-zfs.adoc | 36 +----------------------------------- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index c64fb27..bcd02f7 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -627,41 +627,7 @@ You *must reboot* to activate these changes. SWAP on ZFS ~~~~~~~~~~~ -Swap-space created on a zvol may generate some troubles, like blocking the -server or generating a high IO load, often seen when starting a Backup -to an external Storage. - -We strongly recommend to use enough memory, so that you normally do not -run into low memory situations. Should you need or want to add swap, it is -preferred to create a partition on a physical disk and use it as a swap device. -You can leave some space free for this purpose in the advanced options of the -installer. Additionally, you can lower the -``swappiness'' value. A good value for servers is 10: - ----- -# sysctl -w vm.swappiness=10 ----- - -To make the swappiness persistent, open `/etc/sysctl.conf` with -an editor of your choice and add the following line: - --------- -vm.swappiness = 10 --------- - -.Linux kernel `swappiness` parameter values -[width="100%",cols="<m,2d",options="header"] -|=========================================================== -| Value | Strategy -| vm.swappiness = 0 | The kernel will swap only to avoid -an 'out of memory' condition -| vm.swappiness = 1 | Minimum amount of swapping without -disabling it entirely. -| vm.swappiness = 10 | This value is sometimes recommended to -improve performance when sufficient memory exists in a system. -| vm.swappiness = 60 | The default value. -| vm.swappiness = 100 | The kernel will swap aggressively. -|=========================================================== +It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks freezing thge affected system and other unpredictable behavior. The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns against using a ZFS volume for a swap partition. [[zfs_encryption]] Encrypted ZFS Datasets -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos. 2024-12-17 10:11 [pve-devel] [Typo corrected. 0/2] *** Corrections *** Alexander Abraham 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 1/2] Section on ZFS and swap corrected Alexander Abraham @ 2024-12-17 10:11 ` Alexander Abraham 2024-12-19 12:32 ` Fiona Ebner 1 sibling, 1 reply; 4+ messages in thread From: Alexander Abraham @ 2024-12-17 10:11 UTC (permalink / raw) To: pve-devel; +Cc: Alexander Abraham --- local-zfs.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index bcd02f7..b662233 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -627,7 +627,8 @@ You *must reboot* to activate these changes. SWAP on ZFS ~~~~~~~~~~~ -It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks freezing thge affected system and other unpredictable behavior. The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns against using a ZFS volume for a swap partition. +It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks. These deadlocks could cause the affected system to freeze. +The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns about using a ZFS volume for a swap partition. [[zfs_encryption]] Encrypted ZFS Datasets -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos. 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos Alexander Abraham @ 2024-12-19 12:32 ` Fiona Ebner 0 siblings, 0 replies; 4+ messages in thread From: Fiona Ebner @ 2024-12-19 12:32 UTC (permalink / raw) To: Proxmox VE development discussion, Alexander Abraham If you send another version of a patch series, please use the "-v <n>, --reroll-count=<n>" option for "git format-patch". As long as you are working on a series, you can "change history" on your local branch. This can be done with "git rebase -i" and "git commit --amend" and (there are also things like "git absorb"), there are plenty tutorials on the web. For the patch at hand, you could fold this change into the previous patch with "--amend" and just send out the corrected patch by itself and... Am 17.12.24 um 11:11 schrieb Alexander Abraham: > --- ...for the corrected patch, put a changelog down here and in the cover letter. By prettying up your local git history, the patches will be easier to review and when applied for real on the shared master branch, the history will be nice to read :) Not related to this series and depends on the situations, just mentioning as a general hint: often one runs into problems during development, and they might then be missing from the "clean" git history. It's often worth mentioning those in commit messages, so they still become a part of history. > local-zfs.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/local-zfs.adoc b/local-zfs.adoc > index bcd02f7..b662233 100644 > --- a/local-zfs.adoc > +++ b/local-zfs.adoc > @@ -627,7 +627,8 @@ You *must reboot* to activate these changes. > SWAP on ZFS > ~~~~~~~~~~~ > > -It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks freezing thge affected system and other unpredictable behavior. The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns against using a ZFS volume for a swap partition. > +It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks. These deadlocks could cause the affected system to freeze. > +The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns about using a ZFS volume for a swap partition. > > [[zfs_encryption]] > Encrypted ZFS Datasets _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-19 12:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-12-17 10:11 [pve-devel] [Typo corrected. 0/2] *** Corrections *** Alexander Abraham 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 1/2] Section on ZFS and swap corrected Alexander Abraham 2024-12-17 10:11 ` [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos Alexander Abraham 2024-12-19 12:32 ` Fiona Ebner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox