From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH cluster/docs/manager/widget-toolkit v3 0/4] fix #5463: add optional Consent Banner on login
Date: Tue, 10 Dec 2024 17:11:54 +0100 [thread overview]
Message-ID: <20241210161158.383142-1-g.goller@proxmox.com> (raw)
The consent text is stored in the datacenter.cfg file and is encoded
using base64. This allows us to support multi-line strings and special
characters. To easily edit the text the existing edit-field
ProxmoxTextAreaField is used. It supports editing and saving
multi-line text and converting it to its base64 representation.
This is the port from the initial PBS implementation and should work
in the same way.
v3:
- limit max characters in backend as well
- set a limit of 63*1024 in the frontend (a bit less than max request body size)
- set a limit of 128kB in the backend
v2, thanks @Thomas:
- limit max characters for consent-text (24000)
- wrap datacenter config read in eval
- fix js indentation
- remove Ext.htmlEncode (this is done by Markdown.parse)
manager:
Gabriel Goller (1):
show optional consent-banner before login
PVE/Service/pveproxy.pm | 13 ++++++++++---
www/index.html.tpl | 3 ++-
www/manager6/dc/OptionView.js | 8 ++++++++
www/manager6/window/LoginWindow.js | 12 +++++++++++-
4 files changed, 31 insertions(+), 5 deletions(-)
cluster:
Gabriel Goller (1):
add consent-text parameter to datacenter config file
src/PVE/DataCenterConfig.pm | 6 ++++++
1 file changed, 6 insertions(+)
docs:
Gabriel Goller (1):
add consent-banner description
pve-gui.adoc | 9 +++++++++
1 file changed, 9 insertions(+)
widget-toolkit:
Gabriel Goller (1):
form: set enforceMaxLength on textareafield
src/form/TextAreaField.js | 1 +
1 file changed, 1 insertion(+)
Summary over all repositories:
7 files changed, 47 insertions(+), 5 deletions(-)
--
Generated by git-murpp 0.7.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-12-10 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 16:11 Gabriel Goller [this message]
2024-12-10 16:11 ` [pve-devel] [PATCH manager v3 1/4] show optional consent-banner before login Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH cluster v3 2/4] add consent-text parameter to datacenter config file Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH docs v3 3/4] add consent-banner description Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH widget-toolkit v3 4/4] form: set enforceMaxLength on textareafield Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210161158.383142-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox