public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab
@ 2024-12-10 15:10 Gabriel Goller
  2024-12-10 15:12 ` Gabriel Goller
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Goller @ 2024-12-10 15:10 UTC (permalink / raw)
  To: pve-devel

Show the ip/hwaddress of the network interfaces of containers in the summary
tab of the container and in the network tab on a per-interface basis.

This series was originally by Leo Nunner: 
https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/

v2, thanks @Dominik:
 - show if ip is static or dynamic (dhcp) 
 - show multiple ips per interface
 - refactor/reuse AgentIPView instead of adding ContainerIPView component
 - various other small improvements

manager:

Gabriel Goller (2):
  lxc: show dynamically assigned IPs in network tab
  guest: refactor and reuse AgentIPView for containers

 www/manager6/Makefile                         |   2 +-
 www/manager6/lxc/Network.js                   |  85 +++++++----
 www/manager6/panel/GuestStatusView.js         | 139 +++++++++++++++++-
 www/manager6/panel/GuestSummary.js            |   2 +-
 .../{qemu/AgentIPView.js => panel/IPView.js}  |  78 ++--------
 5 files changed, 213 insertions(+), 93 deletions(-)
 rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (59%)


container:

Gabriel Goller (1):
  api: return all addresses of an interface

 src/PVE/API2/LXC.pm | 35 +++++++++++++++++++++++++----------
 src/PVE/LXC.pm      |  7 +++++--
 2 files changed, 30 insertions(+), 12 deletions(-)


Summary over all repositories:
  7 files changed, 243 insertions(+), 105 deletions(-)

-- 
Generated by git-murpp 0.7.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab
  2024-12-10 15:10 [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab Gabriel Goller
@ 2024-12-10 15:12 ` Gabriel Goller
  0 siblings, 0 replies; 4+ messages in thread
From: Gabriel Goller @ 2024-12-10 15:12 UTC (permalink / raw)
  To: pve-devel

Ignore this one please, forgot the --suppress-cc again :(
Sorry for the noise.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab
  2024-12-10 15:11 Gabriel Goller
@ 2024-12-12  8:02 ` Fabian Grünbichler
  0 siblings, 0 replies; 4+ messages in thread
From: Fabian Grünbichler @ 2024-12-12  8:02 UTC (permalink / raw)
  To: Proxmox VE development discussion

there is both a bugzilla entry for this, and a patch as well:

https://lore.proxmox.com/pve-devel/mailman.710.1713473387.450.pve-devel@lists.proxmox.com/

granted, both happened after Leo's initial patch below, but please still
coordinate/communicate with Johannes as well ;)

On December 10, 2024 4:11 pm, Gabriel Goller wrote:
> Show the ip/hwaddress of the network interfaces of containers in the summary
> tab of the container and in the network tab on a per-interface basis.
> 
> This series was originally by Leo Nunner: 
> https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/
> 
> v2, thanks @Dominik:
>  - show if ip is static or dynamic (dhcp) 
>  - show multiple ips per interface
>  - refactor/reuse AgentIPView instead of adding ContainerIPView component
>  - various other small improvements
> 
> manager:
> 
> Gabriel Goller (2):
>   lxc: show dynamically assigned IPs in network tab
>   guest: refactor and reuse AgentIPView for containers
> 
>  www/manager6/Makefile                         |   2 +-
>  www/manager6/lxc/Network.js                   |  85 +++++++----
>  www/manager6/panel/GuestStatusView.js         | 139 +++++++++++++++++-
>  www/manager6/panel/GuestSummary.js            |   2 +-
>  .../{qemu/AgentIPView.js => panel/IPView.js}  |  78 ++--------
>  5 files changed, 213 insertions(+), 93 deletions(-)
>  rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (59%)
> 
> 
> container:
> 
> Gabriel Goller (1):
>   api: return all addresses of an interface
> 
>  src/PVE/API2/LXC.pm | 35 +++++++++++++++++++++++++----------
>  src/PVE/LXC.pm      |  7 +++++--
>  2 files changed, 30 insertions(+), 12 deletions(-)
> 
> 
> Summary over all repositories:
>   7 files changed, 243 insertions(+), 105 deletions(-)
> 
> -- 
> Generated by git-murpp 0.7.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab
@ 2024-12-10 15:11 Gabriel Goller
  2024-12-12  8:02 ` Fabian Grünbichler
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Goller @ 2024-12-10 15:11 UTC (permalink / raw)
  To: pve-devel

Show the ip/hwaddress of the network interfaces of containers in the summary
tab of the container and in the network tab on a per-interface basis.

This series was originally by Leo Nunner: 
https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/

v2, thanks @Dominik:
 - show if ip is static or dynamic (dhcp) 
 - show multiple ips per interface
 - refactor/reuse AgentIPView instead of adding ContainerIPView component
 - various other small improvements

manager:

Gabriel Goller (2):
  lxc: show dynamically assigned IPs in network tab
  guest: refactor and reuse AgentIPView for containers

 www/manager6/Makefile                         |   2 +-
 www/manager6/lxc/Network.js                   |  85 +++++++----
 www/manager6/panel/GuestStatusView.js         | 139 +++++++++++++++++-
 www/manager6/panel/GuestSummary.js            |   2 +-
 .../{qemu/AgentIPView.js => panel/IPView.js}  |  78 ++--------
 5 files changed, 213 insertions(+), 93 deletions(-)
 rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (59%)


container:

Gabriel Goller (1):
  api: return all addresses of an interface

 src/PVE/API2/LXC.pm | 35 +++++++++++++++++++++++++----------
 src/PVE/LXC.pm      |  7 +++++--
 2 files changed, 30 insertions(+), 12 deletions(-)


Summary over all repositories:
  7 files changed, 243 insertions(+), 105 deletions(-)

-- 
Generated by git-murpp 0.7.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-12  8:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-10 15:10 [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab Gabriel Goller
2024-12-10 15:12 ` Gabriel Goller
2024-12-10 15:11 Gabriel Goller
2024-12-12  8:02 ` Fabian Grünbichler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal