* [pve-devel] [PATCH pve-storage] esxi: anchor vmdk regex in `parse_volname`
@ 2024-12-10 9:16 Shannon Sterz
2024-12-10 9:22 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Sterz @ 2024-12-10 9:16 UTC (permalink / raw)
To: pve-devel
otherwise, `volname.vmdk.raw` would be picked up as a `vmdk` formatted
image, which may not be desired.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/PVE/Storage/ESXiPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index ae10511..37f9e75 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -421,7 +421,7 @@ sub parse_volname {
return ('import', $volname, 0, undef, undef, undef, 'vmx') if $volname =~ /\.vmx$/;
my $format = 'raw';
- $format = 'vmdk' if $volname =~ /\.vmdk/;
+ $format = 'vmdk' if $volname =~ /\.vmdk$/;
return ('images', $volname, 0, undef, undef, undef, $format);
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH pve-storage] esxi: anchor vmdk regex in `parse_volname`
2024-12-10 9:16 [pve-devel] [PATCH pve-storage] esxi: anchor vmdk regex in `parse_volname` Shannon Sterz
@ 2024-12-10 9:22 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-12-10 9:22 UTC (permalink / raw)
To: Proxmox VE development discussion, Shannon Sterz
Am 10.12.24 um 10:16 schrieb Shannon Sterz:
> otherwise, `volname.vmdk.raw` would be picked up as a `vmdk` formatted
> image, which may not be desired.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/PVE/Storage/ESXiPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-10 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-10 9:16 [pve-devel] [PATCH pve-storage] esxi: anchor vmdk regex in `parse_volname` Shannon Sterz
2024-12-10 9:22 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox