From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH stable-7 guest-common] storage tunnel: correctly set disk-import parameters
Date: Fri, 29 Nov 2024 12:54:40 +0100 [thread overview]
Message-ID: <20241129115440.30103-1-f.ebner@proxmox.com> (raw)
From: Fabian Grünbichler <f.gruenbichler@proxmox.com>
according to the schema, else some combinations of migration / guest /
storage settings will fail validation:
2024-05-15 11:48:51 ERROR: migration_snapshot: type check ('boolean') failed - got ''
since this is client / source side, remote migrations to a remote node
with validation enabled can fail without this change.
The fact that this is required for Proxmox VE 7 was reported in the
community forum:
https://forum.proxmox.com/threads/158202/
While Proxmox VE 7 is end-of-life since the end of July 2024, it's
still nice to keep upgrade paths to supported versions open.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit 172ab9f5ccc40666478f2f83696e6b1e62090e2a)
[FE: add rationale for backport]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/StorageTunnel.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/StorageTunnel.pm b/src/PVE/StorageTunnel.pm
index 41147dd..e6390df 100644
--- a/src/PVE/StorageTunnel.pm
+++ b/src/PVE/StorageTunnel.pm
@@ -50,13 +50,13 @@ sub storage_migrate {
my $disk_import_opts = {
format => $format,
storage => $targetsid,
- snapshot => $snapshot,
- migration_snapshot => $migration_snapshot,
+ migration_snapshot => $migration_snapshot ? 1 : 0,
with_snapshots => $with_snapshots,
allow_rename => !$opts->{is_vmstate},
export_formats => join(",", @export_formats),
volname => $name,
};
+ $disk_import_opts->{snapshot} = $snapshot if $snapshot;
my $res = PVE::Tunnel::write_tunnel($tunnel, 600, 'disk-import', $disk_import_opts);
my $local = "/run/pve/$local_vmid.storage";
if (!$tunnel->{forwarded}->{$local}) {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2024-11-29 11:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129115440.30103-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox