public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] unconfigured.sh: set kernel.printk to level warn
Date: Tue, 26 Nov 2024 19:42:11 +0100	[thread overview]
Message-ID: <20241126184211.988025-1-s.ivanov@proxmox.com> (raw)

we got a few reports of kernel-output drawing over the TUI-installer.
(e.g. when ZFS loads for the pool-cleanup, also mkfs.xfs sometimes
triggers a message being printed).

As the information gets logged in the kernel ringbuffer (`dmesg`)
anyways, there's little gain on having it displayed on the console in
addition.

following https://www.kernel.org/doc/Documentation/sysctl/kernel.txt
and
https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/html/managing_monitoring_and_updating_the_kernel/getting-started-with-kernel-logging_managing-monitoring-and-updating-the-kernel
simply set the sysctl to log only messages of level warn and above to
the console.

Tested in a VM, where I manually ran the command before starting the
TUI installer (and selecting XFS as filesystem there). without it the
messages got displayed, with the command they did not.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
as it's a cosmetic issue I would not pull it in late in the release cycle.
Sending it nonetheless now, in order not to forget it.

 unconfigured.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/unconfigured.sh b/unconfigured.sh
index 070cf33..ef9aa3c 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -233,6 +233,9 @@ chronyd || echo "starting chrony failed ($?)"
 echo "Starting a root shell on tty3."
 setsid /sbin/agetty -a root --noclear tty3 &
 
+echo "Setting console loglevel to warn."
+sysctl -w kernel.printk='4 4 1 7'
+
 /usr/bin/proxmox-low-level-installer dump-env
 
 if [ $proxtui -ne 0 ]; then
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2024-11-26 18:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126184211.988025-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal