From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v3] fix #3588: helper: consider NIC count for config-specific timeout
Date: Tue, 26 Nov 2024 15:52:38 +0100 [thread overview]
Message-ID: <20241126145238.141675-1-h.laimer@proxmox.com> (raw)
There have been some reports about `qm start` timeouts on VMs that have a
lot of NICs assigned.
This patch considers the number of NICs when calculating the config-specific
timeout. Since the increase in start time is linearly related to the number
of NICs, a constant timeout increment per NIC was chosen.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
changes since v3:
* move scalar() to wrap grep...
* match against `\d+` instead of `\d{1,2}`
PVE/QemuServer/Helpers.pm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
index 15e2496c..72a46a0a 100644
--- a/PVE/QemuServer/Helpers.pm
+++ b/PVE/QemuServer/Helpers.pm
@@ -167,6 +167,15 @@ sub config_aware_timeout {
$timeout = 150;
}
+ # Some testing showed that adding a NIC increased the start time by ~450ms
+ # consistently across different NIC models, options and already existing
+ # number of NICs.
+ # So 10x that to account for any potential system differences seemed
+ # reasonable. User reports with real-life values (20+: ~50s, 25: 45s, 17: 42s)
+ # also make this seem a good value.
+ my $nic_count = scalar (grep { /^net\d+/ } keys %{$config});
+ $timeout += $nic_count * 5;
+
return $timeout;
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2024-11-26 14:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126145238.141675-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox