From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-firewall 1/2] clippy: useless use of `format!`
Date: Mon, 25 Nov 2024 17:18:32 +0100 [thread overview]
Message-ID: <20241125161833.216598-1-s.hanreich@proxmox.com> (raw)
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-firewall/src/firewall.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-firewall/src/firewall.rs b/proxmox-firewall/src/firewall.rs
index cdbe401..88fb460 100644
--- a/proxmox-firewall/src/firewall.rs
+++ b/proxmox-firewall/src/firewall.rs
@@ -96,7 +96,7 @@ impl Firewall {
}
fn guest_invalid_conntrack_chain() -> ChainPart {
- ChainPart::new(Self::guest_table(), format!("invalid-conntrack"))
+ ChainPart::new(Self::guest_table(), "invalid-conntrack".to_string())
}
fn host_conntrack_chain() -> ChainPart {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-25 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 16:18 Stefan Hanreich [this message]
2024-11-25 16:18 ` [pve-devel] [PATCH proxmox-ve-rs 2/2] clippy: you should consider adding a `Default` implementation for `Group` Stefan Hanreich
2024-11-25 21:06 ` [pve-devel] applied-series: [PATCH proxmox-firewall 1/2] clippy: useless use of `format!` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125161833.216598-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox