From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2] first-boot: multi-user: start after product-specific API proxy
Date: Tue, 19 Nov 2024 16:13:44 +0100 [thread overview]
Message-ID: <20241119151443.457187-1-c.heiss@proxmox.com> (raw)
First of, multi-user.target does not seem to really provide any (strong)
ordering guarantee, it seems.
Instead, let the "fully-up" ordering from the auto-installer depend on
the product-specific API proxy instead.
That way, it is ensured that 1) the system really is fully up and 2)
that users could even use the API / CLI commands, or write files to
pmxcfs (in case of PVE).
After= and Wants= ignore non-existent units, so we can just specify all
three API proxy units here w/o any conditional.
Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
That systemd ignores non-existent for After= and Wants= was definitely a
TIL for me, but very convenient in this case :^)
v1: https://lore.proxmox.com/pve-devel/20241119143946.370202-1-c.heiss@proxmox.com/
proxmox-first-boot/etc/proxmox-first-boot-multi-user.service | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
index d3c798d..a99d826 100644
--- a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
+++ b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
@@ -1,6 +1,7 @@
[Unit]
Description=Proxmox First Boot Setup (Fully Booted)
-After=systemd-remount-fs.service
+After=systemd-remount-fs.service pveproxy.service pmgproxy.service proxmox-backup-proxy.service
+Wants=pveproxy.service pmgproxy.service proxmox-backup-proxy.service
ConditionPathExists=/var/lib/proxmox-first-boot/pending-first-boot-setup
ConditionPathIsReadWrite=/var/lib
--
2.47.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-19 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 15:13 Christoph Heiss [this message]
2024-11-19 16:21 ` Thomas Lamprecht
2024-11-19 17:47 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119151443.457187-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox