From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit] utils: never translate systemd unit states
Date: Tue, 19 Nov 2024 14:02:53 +0100 [thread overview]
Message-ID: <20241119130253.230740-1-c.ebner@proxmox.com> (raw)
Translating unit states might be counter productive in case of
debugging, opt for not translating them and drop usage of the
translation helper.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
src/Utils.js | 12 ------------
src/node/ServiceView.js | 10 ++--------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/src/Utils.js b/src/Utils.js
index 978b558..1ee4039 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -306,18 +306,6 @@ utilities: {
return Ext.htmlEncode(username);
},
- systemdStates: {
- 'enabled': gettext('enabled'),
- 'disabled': gettext('disabled'),
- 'running': gettext('running'),
- 'dead': gettext('dead'),
- 'not-found': gettext('not installed'),
- 'static': gettext('static'),
- 'reload': gettext('reload'),
- 'start': gettext('starting'),
- 'stop': gettext('stopping'),
- },
-
getStoredAuth: function() {
let storedAuth = JSON.parse(window.localStorage.getItem('ProxmoxUser'));
return storedAuth || {};
diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js
index 94f523c..210dd83 100644
--- a/src/node/ServiceView.js
+++ b/src/node/ServiceView.js
@@ -201,10 +201,7 @@ Ext.define('Proxmox.node.ServiceView', {
width: 100,
sortable: true,
dataIndex: 'state',
- renderer: (value, meta, rec) => {
- const state = rec.get('state');
- return Proxmox.Utils.systemdStates[state] ?? state;
- },
+ renderer: (value, meta, rec) => rec.get('state'),
},
{
header: gettext('Active'),
@@ -219,10 +216,7 @@ Ext.define('Proxmox.node.ServiceView', {
sortable: true,
hidden: !Ext.Array.contains(['PVEAuthCookie', 'PBSAuthCookie'], Proxmox?.Setup?.auth_cookie_name),
dataIndex: 'unit-state',
- renderer: (value, meta, rec) => {
- const unitState = rec.get('unit-state');
- return Proxmox.Utils.systemdStates[unitState] ?? unitState;
- },
+ renderer: (value, meta, rec) => rec.get('unit-state'),
},
{
header: gettext('Description'),
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-19 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 13:02 Christian Ebner [this message]
2024-11-19 14:30 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119130253.230740-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox