public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox-mail-forward] buildsys: set setuid bit in installed proxmox-mail-forward binary
@ 2024-11-19 12:12 Lukas Wagner
  2024-11-19 17:48 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2024-11-19 12:12 UTC (permalink / raw)
  To: pve-devel

A previous commit removed the part which sets the bit.
Without the bit we cannot read the notification config, because
Postfix invokes forwarding binaries as 'nobody'.

Fixes: 32d813ce44b ("build: properly use cargo wrapper")
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 3ac0f8b..e6a7553 100644
--- a/Makefile
+++ b/Makefile
@@ -55,6 +55,7 @@ cargo-build:
 install: cargo-build
 	install -dm755 $(DESTDIR)/usr/bin
 	$(CARGO) install
+	chmod u+s $(DESTDIR)/usr/bin/$(PACKAGE)
 
 .PHONY: upload
 upload: $(DEBS)
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH proxmox-mail-forward] buildsys: set setuid bit in installed proxmox-mail-forward binary
  2024-11-19 12:12 [pve-devel] [PATCH proxmox-mail-forward] buildsys: set setuid bit in installed proxmox-mail-forward binary Lukas Wagner
@ 2024-11-19 17:48 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-19 17:48 UTC (permalink / raw)
  To: Proxmox VE development discussion, Lukas Wagner

Am 19.11.24 um 13:12 schrieb Lukas Wagner:
> A previous commit removed the part which sets the bit.
> Without the bit we cannot read the notification config, because
> Postfix invokes forwarding binaries as 'nobody'.
> 
> Fixes: 32d813ce44b ("build: properly use cargo wrapper")
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-19 17:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-19 12:12 [pve-devel] [PATCH proxmox-mail-forward] buildsys: set setuid bit in installed proxmox-mail-forward binary Lukas Wagner
2024-11-19 17:48 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal