From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: resource tree: add collapse/expand all button
Date: Tue, 19 Nov 2024 10:22:24 +0100 [thread overview]
Message-ID: <20241119092224.785853-1-d.csapak@proxmox.com> (raw)
which defaults to expand all, and only if all expanded, collapse all.
Changes icon dynamically when nodes expand/collapse.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
if we'd find an icon that would fit for both cases, we could omit the
event bubbling probably. If there are many nodes, the 'hasCollapsed'
check will trigger more often, iterating over all tree nodes..
www/manager6/Workspace.js | 20 ++++++++++++++++++++
www/manager6/tree/ResourceTree.js | 31 +++++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 922e01df..7bc2aeea 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -260,6 +260,15 @@ Ext.define('PVE.StdWorkspace', {
},
},
},
+ listeners: {
+ expansionchange: function(tree) {
+ if (tree.hasCollapsed()) {
+ me.down('#collapseButton').setIconCls('fa fa-fw fa-plus-square-o x-btn-icon-el-default-toolbar-small');
+ } else {
+ me.down('#collapseButton').setIconCls('fa fa-fw fa-minus-square-o x-btn-icon-el-default-toolbar-small');
+ }
+ },
+ },
});
selview.on('select', function(combo, records) {
@@ -470,6 +479,17 @@ Ext.define('PVE.StdWorkspace', {
padding: '0 0 5 0',
items: [
selview,
+ {
+ xtype: 'button',
+ cls: 'x-btn-default-toolbar-small',
+ itemId: 'collapseButton',
+ tooltip: gettext('Expand/Collapse Tree'),
+ iconCls: 'fa fa-fw fa-plus-square-o x-btn-icon-el-default-toolbar-small',
+ handler: () => {
+ let rt = me.down('pveResourceTree');
+ rt.toggleExpansion();
+ },
+ },
{
xtype: 'button',
cls: 'x-btn-default-toolbar-small',
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 8b7c2521..cef869f7 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -255,6 +255,30 @@ Ext.define('PVE.tree.ResourceTree', {
return changed;
},
+ hasCollapsed: function() {
+ let me = this;
+ let root = me.store.getRootNode();
+ let collapsed = false;
+ root.cascade(function(rec) {
+ if (!rec.isExpanded() && !rec.isLeaf()) {
+ collapsed = true;
+ return false;
+ }
+ return true;
+ });
+ return collapsed;
+ },
+
+ toggleExpansion: function() {
+ let me = this;
+ let root = me.store.getRootNode();
+ if (me.hasCollapsed()) {
+ root.expandChildren(true);
+ } else {
+ root.collapseChildren(false);
+ }
+ },
+
initComponent: function() {
let me = this;
me.saveSortingOptions();
@@ -562,6 +586,13 @@ Ext.define('PVE.tree.ResourceTree', {
rstore.on("load", updateTree);
rstore.startUpdate();
+ store.on('nodeexpand', function() {
+ me.fireEvent('expansionchange', me);
+ });
+ store.on('nodecollapse', function() {
+ me.fireEvent('expansionchange', me);
+ });
+
me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => {
me.store.getRootNode().cascadeBy({
before: function(node) {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-19 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:22 Dominik Csapak [this message]
2024-11-19 9:30 ` Thomas Lamprecht
2024-11-19 9:36 ` Dominik Csapak
2024-11-19 9:39 ` Thomas Lamprecht
2024-11-19 9:41 ` Dominik Csapak
2024-11-19 9:46 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119092224.785853-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox