[pve-devel] [PATCH docs/qemu-server/manager] improving docs & consistency for ova/ovf import

[pve-devel] [PATCH docs/qemu-server/manager] improving docs & consistency for ova/ovf import

[Dominik Csapak]

adding docs section, unifying wording and adding help button to the
import wizard

pve-docs:

Dominik Csapak (1):
  qm: adapt import section to newly added OVA/OVF import

 qm.adoc | 35 ++++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)

qemu-server:

Dominik Csapak (1):
  api: import working storage: improve error message

 PVE/API2/Qemu.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

pve-manager:

Dominik Csapak (2):
  ui: import: add onlineHelp reference
  ui: import: clarify working storage emptyText

 www/manager6/window/GuestImport.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs 1/1] qm: adapt import section to newly added OVA/OVF import

[Dominik Csapak]

remove reference to future ova support and only esxi as supported.

Add extra OVA/OVF section explaining some caveats.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 qm.adoc | 35 ++++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)

diff --git a/qm.adoc b/qm.adoc
index bf53e11..2ffa4ef 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1650,8 +1650,7 @@ model and reduced downtime.
 
 NOTE: The import wizard was added during the {pve} 8.2 development cycle and is
 in tech preview state. While it's already promising and working stable, it's
-still under active development, focusing on adding other import-sources, like
-for example OVF/OVA files, in the future.
+still under active development.
 
 To use the import wizard you have to first set up a new storage for an import
 source, you can do so on the web-interface under _Datacenter -> Storage -> Add_.
@@ -1666,17 +1665,39 @@ wizard. You can modify a subset of the available options here and then start the
 import. Please note that you can do more advanced modifications after the import
 finished.
 
-TIP: The import wizard is currently (2024-03) available for ESXi and has been
-tested with ESXi versions 6.5 through 8.0. Note that guests using vSAN storage
-cannot be directly imported directly; their disks must first be moved to another
-storage. While it is possible to use a vCenter as the import source, performance
-is dramatically degraded (5 to 10 times slower).
+TIP: The ESXi import wizard  has been tested with ESXi versions 6.5 through
+8.0. Note that guests using vSAN storage cannot be directly imported directly;
+their disks must first be moved to another storage. While it is possible to use
+a vCenter as the import source, performance is dramatically degraded (5 to 10
+times slower).
 
 For a step-by-step guide and tips for how to adapt the virtual guest to the new
 hyper-visor see our
 https://pve.proxmox.com/wiki/Migrate_to_Proxmox_VE#Migration[migrate to {pve}
 wiki article].
 
+OVA/OVF Import
+^^^^^^^^^^^^^^
+
+To import OVA/OVF files, you first need a File-based storage with the 'import'
+content type. On this storage, there will be an 'import' folder where you can
+put OVA files or OVF files with the corresponding images in a flat structure.
+Alternatively you can use the web ui to upload or download OVA files directly.
+You can then use the web ui to select those and use the import wizard to import
+the guests.
+
+For OVA files, there is additional space needed to temporarily extract the
+image. This needs a file-based storage that has the 'images' content type
+configured. By default the source storage is selected for this, but you can
+specify a 'Import Working Storage' on which the images will be extracted before
+importing to the actual target storage.
+
+NOTE: Since OVA/OVF file structure and content are not always well maintained
+or defined, it might be necessary to adapt some guest settings manually. For
+example the SCSI controller type is almost never defined in OVA/OVF files, but
+the default is unbootable with OVMF (UEFI), so you should select 'Virtio SCSI'
+or 'VMware PVSCSI' for these cases.
+
 Import OVF/OVA Through CLI
 ~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server 1/1] api: import working storage: improve error message

[Dominik Csapak]

the ui and api talks about 'import working storage' but the error here
still said 'for extraction'. Improve the message by unifiying the
wording and adding the storage name to it too.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Qemu.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 01ad167a..53ff7092 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -178,14 +178,15 @@ my $check_storage_access = sub {
 			? PVE::Storage::storage_config($storecfg, $extraction_storage)
 			: $scfg;
 		    my $extraction_param = defined($extraction_storage) ? 'import-working-storage' : $ds;
+		    my $extraction_id = $extraction_storage // $storeid;
 
 		    if (!$extraction_scfg->{content}->{images} || !$extraction_scfg->{path}) {
 			raise_param_exc({
-			    $extraction_param => "storage selected for extraction does not support"
+			    $extraction_param => "import working storage '$extraction_id' does not support"
 				." 'images' content type or is not file based.",
 			});
 		    }
-		    $rpcenv->check($authuser, "/storage/" . ($extraction_storage // $storeid), ['Datastore.AllocateSpace']);
+		    $rpcenv->check($authuser, "/storage/$extraction_id", ['Datastore.AllocateSpace']);
 		}
 	    }
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/2] ui: import: add onlineHelp reference

[Dominik Csapak]

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/window/GuestImport.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 022e85a3..c242cd3f 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -4,6 +4,8 @@ Ext.define('PVE.window.GuestImport', {
 
     title: gettext('Import Guest'),
 
+    onlineHelp: 'qm_import_virtual_machines',
+
     width: 720,
     bodyPadding: 0,
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] ui: import: clarify working storage emptyText

[Dominik Csapak]

'import storage' is a bit amibuous as to whether it's the storage to
import from or to. To fix that, change it to 'source storage'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/window/GuestImport.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index c242cd3f..107afa51 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -567,7 +567,7 @@ Ext.define('PVE.window.GuestImport', {
 			reference: 'extractionStorage',
 			fieldLabel: gettext('Import Working Storage'),
 			storageContent: 'images',
-			emptyText: gettext('Import Storage'),
+			emptyText: gettext('Source Storage'),
 			autoSelect: false,
 			name: 'import-working-storage',
 			disabled: true,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH docs/qemu-server/manager] improving docs & consistency for ova/ovf import

[Thomas Lamprecht]

Am 19.11.24 um 09:39 schrieb Dominik Csapak:
> adding docs section, unifying wording and adding help button to the
> import wizard
> 
> pve-docs:
> 
> Dominik Csapak (1):
>   qm: adapt import section to newly added OVA/OVF import
> 
>  qm.adoc | 35 ++++++++++++++++++++++++++++-------
>  1 file changed, 28 insertions(+), 7 deletions(-)
> 
> qemu-server:
> 
> Dominik Csapak (1):
>   api: import working storage: improve error message
> 
>  PVE/API2/Qemu.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> pve-manager:
> 
> Dominik Csapak (2):
>   ui: import: add onlineHelp reference
>   ui: import: clarify working storage emptyText
> 
>  www/manager6/window/GuestImport.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 


applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel