From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to
Date: Mon, 18 Nov 2024 11:45:27 +0100 [thread overview]
Message-ID: <20241118104530.91798-1-a.lauterer@proxmox.com> (raw)
Especially in the task-log at the bottom in PVE, users might not realize
that they can open the task log with a double-click. By adding an action
column with a button, this should be easier to discover.
While we are at it, let's have it in the task view panel as well. Here
it can help save clicks for non-double-click users as they don't have to
select and then go to the "view" button.
The tooltip is "View Task". This should leave no ambiguity in that it is
a read-only operation. One patch aligns the button at the top of the
task panel.
Using the "chevron-right" icon was initially done to align with how we
do that in the pbs UI. Especially in the task panel, I stuck with it, as
a test with the "window-open" icon, that is used in the button at the
top, resulted in quite the visual noise IMHO.
Regarding the placement in the grids after a discussion with Dominik:
putting the action column as first column reduces mouse travel, but is a
rather uncommon placement. It would either be seen just as the icon, or
an option to expand/collapse that row.
It is more common, and thus the user expectaion, to have these buttons
rather at the end of the row.
This is why I send the patches with the action columns as the last in
the grid. It is not the only option, one can of course double click
anywhere on the row too.
changes sinve v2:
* add the action column to the tasks panel in the widget toolkit
* align button in the widget toolkits tasks panel to match the tooltip
widget-toolkit: Aaron Lauterer (2):
node tasks: add action column with button to view task
node tasks: align view task button label to other uses
src/node/Tasks.js | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
manager: Aaron Lauterer (1):
ui: tasks: add actioncolumn to open task
www/manager6/dc/Tasks.js | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-18 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 10:45 Aaron Lauterer [this message]
2024-11-18 10:45 ` [pve-devel] [PATCH widget-toolkit v3 1/3] node tasks: add action column with button to view task Aaron Lauterer
2024-11-18 10:45 ` [pve-devel] [PATCH widget-toolkit v3 2/3] node tasks: align view task button label to other uses Aaron Lauterer
2024-11-18 10:45 ` [pve-devel] [PATCH manager v3 3/3] ui: tasks: add actioncolumn to open task Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118104530.91798-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox