public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] dark theme: make icons in the permissions tree in pve dark
@ 2024-11-15 15:29 Shannon Sterz
  2024-11-15 15:49 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Shannon Sterz @ 2024-11-15 15:29 UTC (permalink / raw)
  To: pve-devel

these icons are multiply style because they seem to be handled
differently across products. so this in essence "double inverts" them
in the context where that is needed

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/other/_icons.scss | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
index c045cf4..ad08906 100644
--- a/src/proxmox-dark/scss/other/_icons.scss
+++ b/src/proxmox-dark/scss/other/_icons.scss
@@ -33,6 +33,13 @@
   color: $icon-color;
 }
 
+// pve needs to set `color` on this pseudo element, but the api viewer and pbs
+// add a filter to the parent. so invert it here again, to fix this for pve.
+.x-tree-icon-parent:not(.x-tree-icon-custom)::before,
+.x-tree-icon-parent-expanded:not(.x-tree-icon-custom)::before {
+  filter: invert(90%);
+}
+
 // but some are implement as background SVGs or PNGs. invert them via
 // filters:
 .fa-ceph::before,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH widget-toolkit] dark theme: make icons in the permissions tree in pve dark
  2024-11-15 15:29 [pve-devel] [PATCH widget-toolkit] dark theme: make icons in the permissions tree in pve dark Shannon Sterz
@ 2024-11-15 15:49 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-15 15:49 UTC (permalink / raw)
  To: Proxmox VE development discussion, Shannon Sterz

Am 15.11.24 um 16:29 schrieb Shannon Sterz:
> these icons are multiply style because they seem to be handled
> differently across products. so this in essence "double inverts" them
> in the context where that is needed
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  src/proxmox-dark/scss/other/_icons.scss | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-15 15:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-15 15:29 [pve-devel] [PATCH widget-toolkit] dark theme: make icons in the permissions tree in pve dark Shannon Sterz
2024-11-15 15:49 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal