public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Markus Frank <m.frank@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v12 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices
Date: Fri, 15 Nov 2024 15:00:32 +0100	[thread overview]
Message-ID: <20241115140037.191682-8-m.frank@proxmox.com> (raw)
In-Reply-To: <20241115140037.191682-1-m.frank@proxmox.com>

Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
 PVE/API2/Qemu.pm  | 6 ++++++
 PVE/QemuServer.pm | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index a369a32b..90ed8f81 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -5252,6 +5252,12 @@ __PACKAGE__->register_method({
 
 	my $snapname = extract_param($param, 'snapname');
 
+	# TODO: move to check_non_migratable_resources when applied (SEV patch series)
+	my $vmconf = PVE::QemuConfig->load_config($vmid);
+	my $vmstate = extract_param($param, 'vmstate');
+	die "Cannot snapshot with including state while virtiofs is in use.\n"
+	    if $vmstate && PVE::QemuServer::Virtiofs::virtiofs_enabled($vmconf);
+
 	die "unable to use snapshot name 'current' (reserved name)\n"
 	    if $snapname eq 'current';
 
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 20d38fe0..e198df83 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6453,6 +6453,10 @@ sub vm_suspend {
 
 	$conf = PVE::QemuConfig->load_config($vmid);
 
+	# TODO: move to check_non_migratable_resources when applied (SEV patch series)
+	die "Cannot hibernate while virtiofs is in use.\n"
+	    if $includestate && PVE::QemuServer::Virtiofs::virtiofs_enabled($conf);
+
 	my $is_backing_up = PVE::QemuConfig->has_lock($conf, 'backup');
 	PVE::QemuConfig->check_lock($conf)
 	    if !($skiplock || $is_backing_up);
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-11-15 14:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15 14:00 [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v12 0/12] virtiofs Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH cluster v12 1/12] add mapping/dir.cfg for resource mapping Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH guest-common v12 2/12] add dir mapping section config Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH docs v12 3/12] add doc section for the shared filesystem virtio-fs Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH qemu-server v12 4/12] control: add virtiofsd as runtime dependency for qemu-server Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH qemu-server v12 5/12] fix #1027: virtio-fs support Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH qemu-server v12 6/12] migration: check for virtiofs devices Markus Frank
2024-11-15 14:00 ` Markus Frank [this message]
2024-11-15 14:00 ` [pve-devel] [PATCH manager v12 08/12] api: add resource map api endpoints for directories Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH manager v12 09/12] ui: add edit window for dir mappings Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH manager v12 10/12] ui: add resource mapping view for directories Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH manager v12 11/12] ui: form: add selector for directory mappings Markus Frank
2024-11-15 14:00 ` [pve-devel] [PATCH manager v12 12/12] ui: add option to add virtio-fs to qemu config Markus Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115140037.191682-8-m.frank@proxmox.com \
    --to=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal