From: Moayad Almalat <m.almalat@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH 0/2] Allow four-octet MAC perfixes
Date: Fri, 15 Nov 2024 09:49:22 +0100 [thread overview]
Message-ID: <20241115084923.73207-1-m.almalat@proxmox.com> (raw)
This patch series enables support for four-octet MAC prefixes in Web UI
Changes are made in both forntend `proxmox-widget-toolkit` and backend `pve-cluster`
Thank you @Shannon for your hint in my first attempt :)
Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
---
src/PVE/DataCenterConfig.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index abd0bbf..98e5599 100644
--- a/src/PVE/DataCenterConfig.pm
+++ b/src/PVE/DataCenterConfig.pm
@@ -199,7 +199,7 @@ PVE::JSONSchema::register_format('mac-prefix', \&pve_verify_mac_prefix);
sub pve_verify_mac_prefix {
my ($mac_prefix, $noerr) = @_;
- if ($mac_prefix !~ m/^[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}:?$/i) {
+ if ($mac_prefix !~ m/^[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}(?::[a-f0-9]{0,2})?:?$/i) {
return undef if $noerr;
die "value is not a valid unicast MAC address prefix\n";
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-15 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 8:49 Moayad Almalat [this message]
2024-11-15 8:49 ` [pve-devel] [PATCH] fix: allow four-octet MAC prefixes in Web UI validation Moayad Almalat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115084923.73207-1-m.almalat@proxmox.com \
--to=m.almalat@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox