From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v5 7/9] ui: guest import: add storage selector for ova extraction storage
Date: Thu, 14 Nov 2024 10:32:24 +0100 [thread overview]
Message-ID: <20241114093226.814530-24-d.csapak@proxmox.com> (raw)
In-Reply-To: <20241114093226.814530-1-d.csapak@proxmox.com>
but only when we detect the 'ova-needs-extraction' warning.
This can be used to select the storage where the disks contained in an
OVA will be extracted to temporarily.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/window/GuestImport.js | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 1483d97f..56417f27 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -303,6 +303,7 @@ Ext.define('PVE.window.GuestImport', {
os: 'l26',
maxCdDrives: false,
uniqueMACAdresses: false,
+ isOva: false,
warnings: [],
},
@@ -432,6 +433,10 @@ Ext.define('PVE.window.GuestImport', {
}
}
+ if (config['import-extraction-storage'] === '') {
+ delete config['import-extraction-storage'];
+ }
+
return config;
},
@@ -553,6 +558,22 @@ Ext.define('PVE.window.GuestImport', {
allowBlank: false,
fieldLabel: gettext('Default Bridge'),
},
+ {
+ xtype: 'pveStorageSelector',
+ reference: 'extractionStorage',
+ fieldLabel: gettext('Extraction Storage'),
+ storageContent: 'images',
+ emptyText: gettext('Import Storage'),
+ autoSelect: false,
+ name: 'import-extraction-storage',
+ disabled: true,
+ hidden: true,
+ allowBlank: true,
+ bind: {
+ disabled: '{!isOva}',
+ hidden: '{!isOva}',
+ },
+ },
],
columnB: [
@@ -925,6 +946,7 @@ Ext.define('PVE.window.GuestImport', {
me.lookup('defaultStorage').setNodename(me.nodename);
me.lookup('defaultBridge').setNodename(me.nodename);
+ me.lookup('extractionStorage').setNodename(me.nodename);
let renderWarning = w => {
const warningsCatalogue = {
@@ -1006,6 +1028,7 @@ Ext.define('PVE.window.GuestImport', {
}
me.getViewModel().set('warnings', data.warnings.map(w => renderWarning(w)));
+ me.getViewModel().set('isOva', data.warnings.map(w => w.type).indexOf('ova-needs-extracting') !== -1);
let osinfo = PVE.Utils.get_kvm_osinfo(me.vmConfig.ostype ?? '');
let prepareForVirtIO = (me.vmConfig.ostype ?? '').startsWith('w') && (me.vmConfig.bios ?? '').indexOf('ovmf') !== -1;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-14 9:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 9:32 [pve-devel] [PATCH storage/qemu-server/manager v5] implement ova/ovf import for file based storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 01/12] copy OVF.pm from qemu-server Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 02/12] plugin: dir: implement import content type Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 03/12] plugin: dir: handle ova files for import Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 04/12] ovf: improve and simplify path checking code Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 05/12] ovf: implement parsing the ostype Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 06/12] ovf: implement parsing out firmware type Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 07/12] ovf: implement rudimentary boot order Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 08/12] ovf: implement parsing nics Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 09/12] api: allow ova upload/download Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 10/12] plugin: enable import for nfs/btrfs/cifs/cephfs/glusterfs Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 11/12] add 'import' content type to 'check_volume_access' Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 12/12] plugin: file_size_info: don't ignore base path with whitespace Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 1/4] api: delete unused OVF.pm Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 2/4] use OVF from Storage Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 3/4] api: create: implement extracting disks when needed for import-from Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 4/4] api: create: add 'import-extraction-storage' parameter Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 1/9] ui: fix special 'import' icon for non-esxi storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 2/9] ui: guest import: add ova-needs-extracting warning text Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 3/9] ui: enable import content type for relevant storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 4/9] ui: enable upload/download/remove buttons for 'import' type storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 5/9] ui: disable 'import' button for non importable formats Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 6/9] ui: import: improve rendering of volume names Dominik Csapak
2024-11-14 9:32 ` Dominik Csapak [this message]
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 8/9] ui: guest import: change icon/text for non-esxi import storage Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 9/9] ui: import: show size for dir-based storages Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114093226.814530-24-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox